third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js - Issue 2623063003: DevTools: Fix getCookies to report for all resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js

Issue 2623063003: DevTools: Fix getCookies to report for all resources (Closed)

Patch Set: feedback Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js

index 592c1df34a68c921ed8568b78376197a02c6bd39..992e4b23dd6540ecee55c5bf747b93b3b9fec4d9 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js

@@ -1314,7 +1314,8 @@ Audits.AuditRules.CookieRuleBase = class extends Audits.AuditRule {

callback(result);

}

- SDK.Cookies.getCookiesAsync(resultCallback);

+ const nonDataUrls = requests.map(r => r.url()).filter(url => url && url.asParsedURL());

+ SDK.Cookies.getCookiesAsync(target, nonDataUrls, resultCallback);

}

mapResourceCookies(requestsByDomain, allCookies, callback) {