Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js

Issue 2623063003: DevTools: Fix getCookies to report for all resources (Closed)
Patch Set: audit and line length fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
index 592c1df34a68c921ed8568b78376197a02c6bd39..b6f66b16bdd57624fc3fba825160ac1a8658da9b 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
@@ -1314,7 +1314,8 @@ Audits.AuditRules.CookieRuleBase = class extends Audits.AuditRule {
callback(result);
}
- SDK.Cookies.getCookiesAsync(resultCallback);
+ const nonDataUrls = requests.map(r => r.url()).filter(url => url && !/^data:/.test(url));
pfeldman 2017/01/13 02:17:34 Use ParsedURL to figure out url type.
phulce 2017/01/18 00:52:34 Done.
+ SDK.Cookies.getCookiesAsync(target, nonDataUrls, resultCallback);
}
mapResourceCookies(requestsByDomain, allCookies, callback) {

Powered by Google App Engine
This is Rietveld 408576698