DevTools: Fix getCookies to report for all resources

third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 347 matching lines @@
  * @enum {number}
  */
 SDK.Cookie.Type = {
   Request: 0,
   Response: 1
 };
 
 SDK.Cookies = {};
 
 /**
+ * @param {!SDK.Target} target
+ * @param {!Array.<string>} urls
  * @param {function(!Array.<!SDK.Cookie>)} callback
  */
-SDK.Cookies.getCookiesAsync = function(callback) {
-  var allCookies = [];
-  /**
-   * @param {!SDK.Target} target
-   * @param {?Protocol.Error} error
-   * @param {!Array.<!Protocol.Network.Cookie>} cookies
-   */
-  function mycallback(target, error, cookies) {
-    if (error) {
-      console.error(error);
-      return;
+SDK.Cookies.getCookiesAsync = function(target, urls, callback) {
+  target.networkAgent().getCookies(urls, (err, cookies) => {
+    if (err) {
+      console.error(err);
+      return callback([]);
     }
-    for (var i = 0; i < cookies.length; ++i)
-      allCookies.push(SDK.Cookies._parseProtocolCookie(target, cookies[i]));
-  }
 
-  var barrier = new CallbackBarrier();
-  for (var target of SDK.targetManager.targets(SDK.Target.Capability.Network))
-    target.networkAgent().getCookies(barrier.createCallback(mycallback.bind(null, target)));
-  barrier.callWhenDone(callback.bind(null, allCookies));
+    callback(cookies.map(cookie => SDK.Cookies._parseProtocolCookie(target, cookie)));
+  });
 };
 
 /**
  * @param {!SDK.Target} target
  * @param {!Protocol.Network.Cookie} protocolCookie
  * @return {!SDK.Cookie}
  */
 SDK.Cookies._parseProtocolCookie = function(target, protocolCookie) {
   var cookie = new SDK.Cookie(target, protocolCookie.name, protocolCookie.value, null);
   cookie.addAttribute('domain', protocolCookie['domain']);
@@ skipping 28 matching lines @@
 /**
  * @param {string} cookieDomain
  * @param {string} resourceDomain
  * @return {boolean}
  */
 SDK.Cookies.cookieDomainMatchesResourceDomain = function(cookieDomain, resourceDomain) {
   if (cookieDomain.charAt(0) !== '.')
     return resourceDomain === cookieDomain;
   return !!resourceDomain.match(new RegExp('^([^\\.]+\\.)*' + cookieDomain.substring(1).escapeForRegExp() + '$', 'i'));
 };