third_party/WebKit/Source/core/editing/DragCaretController.h - Issue 2623053006: Get rid of CaretBase::m_caretLocalRect

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/DragCaretController.h

Issue 2623053006: Get rid of CaretBase::m_caretLocalRect (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/editing/CaretBase.cpp ('K') | « third_party/WebKit/Source/core/editing/CaretBase.cpp ('k') | third_party/WebKit/Source/core/editing/DragCaretController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights	2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights

3 * reserved.	3 * reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56 DECLARE_TRACE();	56 DECLARE_TRACE();

57	57

58 private:	58 private:

59 DragCaretController();	59 DragCaretController();

60	60

61 // Implementations of \|SynchronousMutationObserver\|	61 // Implementations of \|SynchronousMutationObserver\|

62 void nodeChildrenWillBeRemoved(ContainerNode&) final;	62 void nodeChildrenWillBeRemoved(ContainerNode&) final;

63 void nodeWillBeRemoved(Node&) final;	63 void nodeWillBeRemoved(Node&) final;

64	64

65 PositionWithAffinity m_position;	65 PositionWithAffinity m_position;

	66 // caret rect in coords local to the layoutObject responsible for painting the

	67 // caret

	68 LayoutRect m_caretLocalRect;

66 const Member<CaretBase> m_caretBase;	69 const Member<CaretBase> m_caretBase;

67 };	70 };

68	71

69 } // namespace blink	72 } // namespace blink

70	73

71 #endif // DragCaretController_h	74 #endif // DragCaretController_h

OLD	NEW