Fasta targets and loaders.

pkg/fasta/lib/src/kernel/kernel_target.dart

Index: pkg/fasta/lib/src/kernel/kernel_target.dart
diff --git a/pkg/fasta/lib/src/kernel/kernel_target.dart b/pkg/fasta/lib/src/kernel/kernel_target.dart
new file mode 100644
index 0000000000000000000000000000000000000000..5e90ba4b70dd46ab6c7d7f853bd3f7c32dce6c5c
--- /dev/null
+++ b/pkg/fasta/lib/src/kernel/kernel_target.dart
@@ -0,0 +1,602 @@
+// Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library fasta.kernel_target;
+
+import 'dart:async' show
+    Future;
+
+import 'dart:io' show
+    File,
+    IOSink;
+
+import 'package:kernel/ast.dart' show
+    Arguments,
+    AsyncMarker,
+    Class,
+    Constructor,
+    EmptyStatement,
+    Expression,
+    ExpressionStatement,
+    Field,
+    FieldInitializer,
+    FunctionNode,
+    Initializer,
+    InvalidInitializer,
+    Library,
+    Name,
+    NamedExpression,
+    NullLiteral,
+    Procedure,
+    ProcedureKind,
+    Program,
+    RedirectingInitializer,
+    ReturnStatement,
+    StaticGet,
+    StringLiteral,
+    SuperInitializer,
+    Throw,
+    VariableDeclaration,
+    VariableGet,
+    VoidType;
+
+import 'package:kernel/binary/ast_to_binary.dart' show
+    BinaryPrinter;
+
+import 'package:kernel/text/ast_to_text.dart' show
+    Printer;
+
+import 'package:kernel/transformations/mixin_full_resolution.dart' show
+    MixinFullResolution,
+    SuperInitializerResolutionTransformer;
+
+import '../source/source_loader.dart' show
+    SourceLoader;
+
+import '../source/source_class_builder.dart' show
+    SourceClassBuilder;
+
+import '../target_implementation.dart' show
+    TargetImplementation;
+
+import '../translate_uri.dart' show
+    TranslateUri;
+
+import '../dill/dill_target.dart' show
+    DillTarget;
+
+import '../dill/dill_member_builder.dart' show
+    DillMemberBuilder;
+
+import '../ast_kind.dart' show
+    AstKind;
+
+import '../errors.dart' show
+    InputError,
+    internalError,
+    reportCrash,
+    resetCrashReporting;
+
+import 'kernel_builder.dart' show
+    Builder,
+    ClassBuilder,
+    DynamicTypeBuilder,
+    InterfaceTypeBuilder,
+    InvalidTypeBuilder,
+    KernelClassBuilder,
+    KernelInterfaceTypeBuilder,
+    KernelLibraryBuilder,
+    KernelProcedureBuilder,
+    LibraryBuilder,
+    MixinApplicationBuilder,
+    NamedMixinApplicationBuilder,
+    TypeBuilder;
+
+class KernelSourceTarget extends TargetImplementation {
+  final DillTarget dillTarget;
+  SourceLoader<Library> loader;
+  Program program;
+
+  final List errors = [];
+
+  KernelSourceTarget(DillTarget dillTarget, TranslateUri uriTranslator)
+      : dillTarget = dillTarget,
+        super(dillTarget.ticker, uriTranslator) {
+    resetCrashReporting();
+    loader = new SourceLoader<Library>(this);
+  }
+
+  void read(Uri uri) {
+    loader.read(uri);
+  }
+
+  LibraryBuilder createLibraryBuilder(Uri uri) {
+    if (dillTarget.isLoaded) {
+      var builder = dillTarget.loader.builders[uri];
+      if (builder != null) {
+        return builder;
+      }
+    }
+    return new KernelLibraryBuilder(uri, loader);
+  }
+
+  void addDirectSupertype(ClassBuilder cls, Set<ClassBuilder> set) {
+    if (cls == null) return;
+    TypeBuilder supertype = cls.supertype;
+    add(InterfaceTypeBuilder type) {
+      Builder builder = type.builder;
+      if (builder is ClassBuilder) {
+        set.add(builder);
+      } else if (builder is! InvalidTypeBuilder &&
+          builder is! DynamicTypeBuilder) {
+        internalError("Unhandled: ${builder.runtimeType}");
+      }
+    }
+    if (supertype == null) {
+      // OK.
+    } else if (supertype is MixinApplicationBuilder) {
+      add(supertype.supertype);
+      for (InterfaceTypeBuilder t in supertype.mixins) {
+        add(t);
+      }
+    } else if (supertype is InterfaceTypeBuilder) {
+      add(supertype);
+    } else {
+      internalError("Unhandled: ${supertype.runtimeType}");
+    }
+    if (cls.interfaces != null) {
+      for (InterfaceTypeBuilder t in cls.interfaces) {
+        add(t);
+      }
+    }
+  }
+
+  List<ClassBuilder> collectAllClasses() {
+    List<ClassBuilder> result = <ClassBuilder>[];
+    loader.builders.forEach((Uri uri, LibraryBuilder library) {
+      library.members.forEach((String name, Builder member) {
+        if (member is KernelClassBuilder) {
+          result.add(member);
+        }
+      });
+      // TODO(ahe): Translate this if needed:
+      // if (library is KernelLibraryBuilder) {
+      //   result.addAll(library.mixinApplicationClasses);
+      // }
+    });
+    return result;
+  }
+
+  List<SourceClassBuilder> collectAllSourceClasses() {
+    List<SourceClassBuilder> result = <SourceClassBuilder>[];
+    loader.builders.forEach((Uri uri, LibraryBuilder library) {
+      library.members.forEach((String name, Builder member) {
+        if (member is SourceClassBuilder) {
+          result.add(member);
+        }
+      });
+    });
+    return result;
+  }
+
+  List<Class> collectAllMixinApplications() {
+    List<Class> result = <Class>[];
+    loader.builders.forEach((Uri uri, LibraryBuilder library) {
+      if (library is KernelLibraryBuilder) {
+        result.addAll(library.mixinApplicationClasses);
+      }
+    });
+    return result;
+  }
+
+  void breakCycle(ClassBuilder builder) {
+    Class cls = builder.target;
+    cls.implementedTypes.clear();
+    cls.supertype = null;
+    cls.mixedInType = null;
+    builder.supertype = new KernelInterfaceTypeBuilder("Object", null)
+        ..builder = objectClassBuilder;
+    builder.interfaces = null;
+  }
+
+  Future<Program> handleInputError(Uri uri, InputError error,
+      {bool isFullProgram}) {
+    if (error != null) {
+      String message = error.format();
+      print(message);
+      errors.add(message);
+    }
+    program = erroneousProgram();
+    return uri == null
+        ? new Future<Program>.value(program)
+        : writeLinkedProgram(uri, program, isFullProgram: isFullProgram);
+  }
+
+  Future<Program> writeProgram(Uri uri, AstKind astKind) async {
+    if (loader.first == null) return null;
+    if (errors.isNotEmpty) {
+      return handleInputError(uri, null, isFullProgram: true);
+    }
+    try {
+      if (astKind == AstKind.Analyzer) {
+        loader.buildElementStore();
+      } else {
+        loader.computeHierarchy(program);
+      }
+      await loader.buildBodies(astKind);
+      loader.finishStaticInvocations();
+      finishAllConstructors();
+      transformMixinApplications();
+      errors.addAll(loader.collectCompileTimeErrors().map((e) => e.format()));
+      if (errors.isNotEmpty) {
+        return handleInputError(uri, null, isFullProgram: true);
+      }
+      if (uri == null) return program;
+      return await writeLinkedProgram(uri, program, isFullProgram: true);
+    } on InputError catch (e) {
+      return handleInputError(uri, e, isFullProgram: true);
+    } catch (e, s) {
+      return reportCrash(e, s, loader?.currentUriForCrashReporting);
+    }
+  }
+
+  Future<Program> writeOutline(Uri uri) async {
+    if (loader.first == null) return null;
+    try {
+      await loader.buildOutlines();
+      loader.resolveParts();
+      loader.computeLibraryScopes();
+      loader.resolveTypes();
+      loader.convertConstructors();
+      loader.buildProgram();
+      loader.checkSemantics();
+      List<SourceClassBuilder> sourceClasses = collectAllSourceClasses();
+      installDefaultSupertypes(sourceClasses);
+      installDefaultConstructors(sourceClasses);
+      loader.resolveConstructors();
+      program = link(new List<Library>.from(loader.libraries));
+      if (uri == null) return program;
+      return await writeLinkedProgram(uri, program, isFullProgram: false);
+    } on InputError catch (e) {
+      return handleInputError(uri, e, isFullProgram: false);
+    } catch (e, s) {
+      return reportCrash(e, s, loader?.currentUriForCrashReporting);
+    }
+  }
+
+  Program erroneousProgram() {
+    Uri uri = loader.first?.uri ?? Uri.parse("error:error");
+    KernelLibraryBuilder library = new KernelLibraryBuilder(uri, loader);
+    KernelProcedureBuilder mainBuilder = new KernelProcedureBuilder(null, 0,
+        null, "main", null, null, AsyncMarker.Sync, ProcedureKind.Method);
+    library.addBuilder(mainBuilder.name, mainBuilder);
+    loader.first = library;
+    mainBuilder.body = new ExpressionStatement(
+        new Throw(new StringLiteral("${errors.join('\n')}")));
+    library.build();
+    return link(<Library>[library.library]);
+  }
+
+  Program link(List<Library> libraries) {

[Johnni Winther, 2017/01/19 09:21:33]

Add dartdoc to this method.

[ahe, 2017/01/19 10:48:30]

Done.

+   Map<String, List<int>> uriToLineStarts = <String, List<int>>{};
+
+    // for (Library library in libraries) {
+    //   // TODO(ahe): Compute line starts instead.
+    //   uriToLineStarts[library.fileUri] = <int>[0];
+    // }
+
+    final Program binary = dillTarget.loader.program;
+    if (binary != null) {
+      libraries.addAll(binary.libraries);
+      uriToLineStarts.addAll(binary.uriToLineStarts);
+    }
+
+    // TODO(ahe): Remove this line. Kernel seems to generate a default line map
+    // that used when there's no fileUri on an element. Instead, ensure all
+    // elements have a fileUri.
+    uriToLineStarts[""] = <int>[0];
+    Program program = new Program(libraries, uriToLineStarts);
+    if (loader.first != null) {
+      Builder builder = loader.first.members["main"];
+      if (builder is KernelProcedureBuilder) {
+        program.mainMethod = builder.procedure;
+      }
+    }
+    // TODO(ahe): This is kinda hackish. Use the transformer instead.
+    LibraryBuilder builtin =
+        dillTarget.loader.builders[Uri.parse("dart:_builtin")];
+    if (builtin != null) {
+      DillMemberBuilder builder = builtin.members["_getMainClosure"];
+      if (builder != null) {
+        Expression getMain = program.mainMethod == null
+            ? new Throw(new StringLiteral("No main method."))
+            : new StaticGet(program.mainMethod);
+        Procedure procedure = builder.member;
+        procedure.function = new FunctionNode(new ReturnStatement(getMain));
+        procedure.function.parent = procedure;
+      }
+    }
+    ticker.logMs("Linked program");
+    return program;
+  }
+
+  Future<Program> writeLinkedProgram(Uri uri, Program program,
+      {bool isFullProgram}) async {
+    File output = new File.fromUri(uri);
+    IOSink sink = output.openWrite();
+    try {
+      new BinaryPrinter(sink).writeProgramFile(program);
+    } finally {
+      await sink.close();
+    }
+    if (isFullProgram) {
+      ticker.logMs("Wrote program to ${uri.toFilePath()}");
+    } else {
+      ticker.logMs("Wrote outline to ${uri.toFilePath()}");
+    }
+    return null;
+  }
+
+  void installDefaultSupertypes(List<SourceClassBuilder> builders) {
+    Class objectClass = this.objectClass;
+    for (SourceClassBuilder builder in builders) {
+      Class cls = builder.target;
+      if (cls != objectClass) {
+        cls.supertype ??= objectClass.asRawSupertype;
+      }
+    }
+    ticker.logMs("Installed Object as implicit superclass");
+  }
+
+  void installDefaultConstructors(List<SourceClassBuilder> builders) {
+    Class objectClass = this.objectClass;
+    for (SourceClassBuilder builder in builders) {
+      if (builder.target != objectClass) {
+        installDefaultConstructor(builder);
+      }
+    }
+    ticker.logMs("Installed default constructors");
+  }
+
+  KernelClassBuilder get objectClassBuilder {
+    return loader.coreLibrary.exports["Object"];
+  }
+
+  Class get objectClass => objectClassBuilder.cls;
+
+  /// If [builder] doesn't have a constructors, install the defaults.
+  void installDefaultConstructor(SourceClassBuilder builder) {
+    if (!builder.constructors.isEmpty) return;
+    /// Quotes below are from [Dart Programming Language Specification, 4th
+    /// Edition](http://www.ecma-international.org/publications/files/ECMA-ST/ECMA-408.pdf):
+    if (builder is NamedMixinApplicationBuilder) {
+      /// >A mixin application of the form S with M; defines a class C with
+      /// >superclass S.
+      /// >...
+
+      /// >Let LM be the library in which M is declared. For each generative
+      /// >constructor named qi(Ti1 ai1, . . . , Tiki aiki), i in 1..n of S
+      /// >that is accessible to LM , C has an implicitly declared constructor
+      /// >named q'i = [C/S]qi of the form q'i(ai1,...,aiki) :
+      /// >super(ai1,...,aiki);.
+      Builder supertype = builder;
+      while (supertype is NamedMixinApplicationBuilder) {
+        NamedMixinApplicationBuilder named = supertype;
+        TypeBuilder type = named.mixinApplication;
+        if (type is MixinApplicationBuilder) {
+          MixinApplicationBuilder t = type;
+          type = t.supertype;
+        }
+        if (type is InterfaceTypeBuilder) {
+          supertype = type.builder;
+        } else {
+          internalError("Unhandled: ${type.runtimeType}");
+        }
+      }
+      if (supertype is KernelClassBuilder) {
+        for (Constructor constructor in supertype.cls.constructors) {
+          builder.addSyntheticConstructor(
+              makeMixinApplicationConstructor(builder.cls.mixin, constructor));
+        }
+      } else {
+        internalError("Unhandled: ${supertype.runtimeType}");
+      }
+    } else {
+      /// >Iff no constructor is specified for a class C, it implicitly has a
+      /// >default constructor C() : super() {}, unless C is class Object.
+      // The superinitializer is installed below in [finishConstructors].
+      builder.addSyntheticConstructor(makeDefaultConstructor());
+    }
+  }
+
+  Constructor makeMixinApplicationConstructor(
+      Class mixin, Constructor constructor) {
+    VariableDeclaration copyFormal(VariableDeclaration formal) {
+      // TODO(ahe): Handle initializers.
+      return new VariableDeclaration(formal.name,
+          type: formal.type, isFinal: formal.isFinal, isConst: formal.isConst);
+    }
+    List<VariableDeclaration> positionalParameters = <VariableDeclaration>[];
+    List<VariableDeclaration> namedParameters = <VariableDeclaration>[];
+    List<Expression> positional = <Expression>[];
+    List<NamedExpression> named = <NamedExpression>[];
+    for (VariableDeclaration formal in
+             constructor.function.positionalParameters) {
+      positionalParameters.add(copyFormal(formal));
+      positional.add(new VariableGet(positionalParameters.last));
+    }
+    for (VariableDeclaration formal in
+             constructor.function.namedParameters) {
+      namedParameters.add(copyFormal(formal));
+      named.add(new NamedExpression(
+              formal.name, new VariableGet(namedParameters.last)));
+    }
+    FunctionNode function = new FunctionNode(new EmptyStatement(),
+        positionalParameters: positionalParameters,
+        namedParameters: namedParameters,
+        requiredParameterCount: constructor.function.requiredParameterCount,
+        returnType: const VoidType());
+    SuperInitializer initializer = new SuperInitializer(
+        constructor, new Arguments(positional, named: named));
+    return new Constructor(function,
+        name: constructor.name,
+        initializers: <Initializer>[initializer]);
+  }
+
+  Constructor makeDefaultConstructor() {
+    return new Constructor(
+        new FunctionNode(new EmptyStatement(), returnType: const VoidType()),
+        name: new Name(""));
+  }
+
+  void finishAllConstructors() {
+    Class objectClass = this.objectClass;
+    for (SourceClassBuilder builder in collectAllSourceClasses()) {
+      Class cls = builder.target;
+      if (cls != objectClass) {
+        finishConstructors(cls);
+      }
+    }
+    ticker.logMs("Finished constructors");
+  }
+
+  /// Ensure constructors of [cls] have the correct initializers and other
+  /// requirements.
+  void finishConstructors(Class cls) {
+    /// Quotes below are from [Dart Programming Language Specification, 4th
+    /// Edition](http://www.ecma-international.org/publications/files/ECMA-ST/ECMA-408.pdf):
+    Constructor superTarget;
+    List<Field> uninitializedFields = <Field>[];
+    for (Field field in cls.fields) {
+      if (field.initializer == null) {
+        uninitializedFields.add(field);
+      }
+    }
+    Map<Constructor, List<FieldInitializer>> fieldInitializers =
+        <Constructor, List<FieldInitializer>>{};
+    for (Constructor constructor in cls.constructors) {
+      if (!isRedirectingGenerativeConstructor(constructor)) {
+        /// >If no superinitializer is provided, an implicit superinitializer
+        /// >of the form super() is added at the end of k’s initializer list,
+        /// >unless the enclosing class is class Object.
+        if (!constructor.initializers.any(isSuperinitializerOrInvalid)) {
+          superTarget ??= defaultSuperConstructor(cls);
+          Initializer initializer;
+          if (superTarget == null) {
+            initializer = new InvalidInitializer();
+          } else {
+            initializer =
+                new SuperInitializer(superTarget, new Arguments.empty());
+          }
+          constructor.initializers.add(initializer);
+          initializer.parent = constructor;
+        }
+        if (constructor.function.body == null) {
+          /// >If a generative constructor c is not a redirecting constructor
+          /// >and no body is provided, then c implicitly has an empty body {}.
+          /// We use an empty statement instead.
+          constructor.function.body = new EmptyStatement();
+          constructor.function.body.parent = constructor.function;
+        }
+        List<FieldInitializer> myFieldInitializers = <FieldInitializer>[];
+        for (Initializer initializer in constructor.initializers) {
+          if (initializer is FieldInitializer) {
+            myFieldInitializers.add(initializer);
+          }
+        }
+        fieldInitializers[constructor] = myFieldInitializers;
+      }
+    }
+    Set<Field> initializedFields;
+    fieldInitializers.forEach(
+        (Constructor constructor, List<FieldInitializer> initializers) {
+      Iterable<Field> fields = initializers.map((i) => i.field);
+      if (initializedFields == null) {
+        initializedFields = new Set<Field>.from(fields);
+      } else {
+        initializedFields.addAll(fields);
+      }
+    });
+    for (Field field in uninitializedFields) {

[Johnni Winther, 2017/01/19 09:21:34]

Add a comment to this and the next loop. The difference in effect is subtle.

[ahe, 2017/01/19 10:48:30]

Done.

+      if (initializedFields == null || !initializedFields.contains(field)) {
+        field.initializer = new NullLiteral()
+            ..parent = field;
+      }
+    }
+    fieldInitializers.forEach(
+        (Constructor constructor, List<FieldInitializer> initializers) {
+      Iterable<Field> fields = initializers.map((i) => i.field);
+      for (Field field in initializedFields.difference(fields.toSet())) {
+        if (field.initializer == null) {
+          FieldInitializer initializer =
+              new FieldInitializer(field, new NullLiteral());
+          initializer.parent = constructor;
+          constructor.initializers.insert(0, initializer);
+        }
+      }
+    });
+  }
+
+  void transformMixinApplications() {
+    new MixinFullResolution().transform(program);
+    ticker.logMs("Transformed mixin applications");
+  }
+
+  void transformMixinApplicationsX() {

[Johnni Winther, 2017/01/19 09:21:34]

Is this used?

[ahe, 2017/01/19 10:48:30]

No. Removed.

+    MixinFullResolution transformer = new MixinFullResolution()
+        ..hierarchy = loader.hierarchy
+        ..coreTypes = loader.coreTypes;
+    Set<Class> transformedClasses = new Set<Class>();
+    Set<Class> processedClasses = new Set<Class>();
+    for (Class cls in collectAllMixinApplications()) {
+      transformer.transformClass(processedClasses, transformedClasses, cls);
+    }
+
+    for (SourceClassBuilder builder in collectAllSourceClasses()) {
+      Class cls = builder.target;
+      if (transformedClasses.contains(cls.superclass)) {
+        for (Constructor constructor in cls.constructors) {
+          new SuperInitializerResolutionTransformer(cls.superclass)
+              .transformInitializers(constructor.initializers);
+        }
+      }
+
+    }
+    ticker.logMs("Transformed mixin applications");
+  }
+
+  void dumpIr() {
+    StringBuffer sb = new StringBuffer();
+    for (Library library in loader.libraries) {
+      Printer printer = new Printer(sb);
+      printer.writeLibraryFile(library);
+    }
+    print("$sb");
+  }
+}
+
+bool isSuperinitializerOrInvalid(Initializer initializer) {
+  return initializer is SuperInitializer
+      || initializer is InvalidInitializer;
+}
+
+bool isRedirectingGenerativeConstructor(Constructor constructor) {
+  List<Initializer> initializers = constructor.initializers;
+  return initializers.length == 1
+      && initializers.single is RedirectingInitializer;
+}
+
+Constructor defaultSuperConstructor(Class cls) {

[Johnni Winther, 2017/01/19 09:21:34]

Add dartdoc that this return a constructor that can be called as a default
constructor (no name, no arguments) - not an implicit default constructor (which
take no arguments).

[ahe, 2017/01/19 10:48:30]

Done.

+  Class superclass = cls.superclass;
+  while (superclass != null && superclass.isMixinApplication) {
+    superclass = superclass.superclass;
+  }
+  for (Constructor constructor in superclass.constructors) {
+    if (constructor.name.name.isEmpty) {
+      return constructor.function.requiredParameterCount == 0 ?
+          constructor : null;
+    }
+  }
+  return null;
+}