[Re-landing] Migrate external protocol prefs from local state to profiles

chrome/browser/ui/cocoa/external_protocol_dialog.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/external_protocol_dialog.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram_macros.h"
 #include "chrome/browser/external_protocol/external_protocol_handler.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/tab_contents/tab_util.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/strings/grit/components_strings.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/gfx/text_elider.h"
 
 ///////////////////////////////////////////////////////////////////////////////
 // ExternalProtocolHandler
@@ skipping 81 matching lines @@
       break;
     case NSAlertSecondButtonReturn:
       blockState = ExternalProtocolHandler::BLOCK;
       break;
     default:
       NOTREACHED();
   }
 
   // Set the "don't warn me again" info.
   if ([[alert_ suppressionButton] state] == NSOnState) {
-    ExternalProtocolHandler::SetBlockState(url_.scheme(), blockState);
+    content::WebContents* web_contents =
+        tab_util::GetWebContentsByID(render_process_host_id_, routing_id_);
+    Profile* profile =
+        Profile::FromBrowserContext(web_contents->GetBrowserContext());
+
+    ExternalProtocolHandler::SetBlockState(url_.scheme(), blockState, profile);
     ExternalProtocolHandler::RecordMetrics(true);
   } else {
     ExternalProtocolHandler::RecordMetrics(false);
   }
 
   if (blockState == ExternalProtocolHandler::DONT_BLOCK) {
     UMA_HISTOGRAM_LONG_TIMES("clickjacking.launch_url",
                              base::Time::Now() - creation_time_);
 
     content::WebContents* web_contents =

[tapted, 2017/01/23 05:07:54]

nit: move this up to line ~110 and reuse

[ramyasharma, 2017/01/23 06:41:26]

Done.

         tab_util::GetWebContentsByID(render_process_host_id_, routing_id_);
 
     ExternalProtocolHandler::LaunchUrlWithoutSecurityCheck(url_, web_contents);
   }
 
   [self autorelease];
 }
 
 @end