[Re-landing] Migrate external protocol prefs from local state to profiles

chrome/browser/external_protocol/external_protocol_handler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/external_protocol/external_protocol_handler.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
+#include "chrome/browser/prefs/browser_prefs.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/testing_profile.h"
+#include "components/prefs/testing_pref_service.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserThread;
 
 class FakeExternalProtocolHandlerWorker
     : public shell_integration::DefaultProtocolClientWorker {
  public:
   FakeExternalProtocolHandlerWorker(
       const shell_integration::DefaultWebClientWorkerCallback& callback,
@@ skipping 27 matching lines @@
         has_blocked_(false) {}
 
   scoped_refptr<shell_integration::DefaultProtocolClientWorker>
   CreateShellWorker(
       const shell_integration::DefaultWebClientWorkerCallback& callback,
       const std::string& protocol) override {
     return new FakeExternalProtocolHandlerWorker(callback, protocol, os_state_);
   }
 
   ExternalProtocolHandler::BlockState GetBlockState(
-      const std::string& scheme) override {
+      const std::string& scheme, Profile* profile) override {
     return block_state_;
   }
 
   void BlockRequest() override {
     ASSERT_TRUE(block_state_ == ExternalProtocolHandler::BLOCK ||
                 os_state_ == shell_integration::IS_DEFAULT);
     has_blocked_ = true;
   }
 
   void RunExternalProtocolDialog(const GURL& url,
@@ skipping 37 matching lines @@
   bool has_prompted_;
   bool has_blocked_;
 };
 
 class ExternalProtocolHandlerTest : public testing::Test {
  protected:
   ExternalProtocolHandlerTest()
       : ui_thread_(BrowserThread::UI, base::MessageLoop::current()),
         file_thread_(BrowserThread::FILE) {}
 
-  void SetUp() override { file_thread_.Start(); }
+  void SetUp() override {
+    file_thread_.Start();
+    local_state_.reset(new TestingPrefServiceSimple);
+    profile_.reset(new TestingProfile());
+    chrome::RegisterLocalState(local_state_->registry());
+    TestingBrowserProcess::GetGlobal()->SetLocalState(local_state_.get());
+  }
 
   void TearDown() override {
     // Ensure that g_accept_requests gets set back to true after test execution.
     ExternalProtocolHandler::PermitLaunchUrl();
+    TestingBrowserProcess::GetGlobal()->SetLocalState(NULL);

[dominickn, 2017/01/19 07:01:22]

Nit: use nullptr instead of NULL

[ramyasharma, 2017/01/20 04:04:45]

Done.

+    local_state_.reset();
   }
 
   void DoTest(ExternalProtocolHandler::BlockState block_state,
               shell_integration::DefaultWebClientState os_state,
               bool should_prompt,
               bool should_launch,
               bool should_block) {
     GURL url("mailto:test@test.com");
     ASSERT_FALSE(delegate_.has_prompted());
     ASSERT_FALSE(delegate_.has_launched());
     ASSERT_FALSE(delegate_.has_blocked());
 
     delegate_.set_block_state(block_state);
     delegate_.set_os_state(os_state);
     ExternalProtocolHandler::LaunchUrlWithDelegate(
         url, 0, 0, ui::PAGE_TRANSITION_LINK, true, &delegate_);
     if (block_state != ExternalProtocolHandler::BLOCK)
       base::RunLoop().Run();
 
     ASSERT_EQ(should_prompt, delegate_.has_prompted());
     ASSERT_EQ(should_launch, delegate_.has_launched());
     ASSERT_EQ(should_block, delegate_.has_blocked());
   }
 
   base::MessageLoopForUI ui_message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread file_thread_;
 
   FakeExternalProtocolHandlerDelegate delegate_;
+
+  std::unique_ptr<TestingPrefServiceSimple> local_state_;
+  std::unique_ptr<TestingProfile> profile_;
 };
 
 TEST_F(ExternalProtocolHandlerTest, TestLaunchSchemeBlockedChromeDefault) {
   DoTest(ExternalProtocolHandler::BLOCK, shell_integration::IS_DEFAULT, false,
          false, true);
 }
 
 TEST_F(ExternalProtocolHandlerTest, TestLaunchSchemeBlockedChromeNotDefault) {
   DoTest(ExternalProtocolHandler::BLOCK, shell_integration::NOT_DEFAULT, false,
          false, true);
@@ skipping 26 matching lines @@
 
 TEST_F(ExternalProtocolHandlerTest, TestLaunchSchemeUnknownChromeNotDefault) {
   DoTest(ExternalProtocolHandler::UNKNOWN, shell_integration::NOT_DEFAULT, true,
          false, false);
 }
 
 TEST_F(ExternalProtocolHandlerTest, TestLaunchSchemeUnknownChromeUnknown) {
   DoTest(ExternalProtocolHandler::UNKNOWN, shell_integration::UNKNOWN_DEFAULT,
          true, false, false);
 }
+
+TEST_F(ExternalProtocolHandlerTest, TestGetBlockStateUnknown) {
+  ExternalProtocolHandler::BlockState block_state =
+    ExternalProtocolHandler::GetBlockState("tel", profile_.get());
+  ASSERT_EQ(ExternalProtocolHandler::UNKNOWN, block_state);
+}
+
+TEST_F(ExternalProtocolHandlerTest, TestGetBlockStateDefaultBlock) {
+  ExternalProtocolHandler::BlockState block_state =
+    ExternalProtocolHandler::GetBlockState("afp", profile_.get());
+  ASSERT_EQ(ExternalProtocolHandler::BLOCK, block_state);
+}
+
+TEST_F(ExternalProtocolHandlerTest, TestGetBlockStateDefaultDontBlock) {
+  ExternalProtocolHandler::BlockState block_state =
+    ExternalProtocolHandler::GetBlockState("mailto", profile_.get());
+  ASSERT_EQ(ExternalProtocolHandler::DONT_BLOCK, block_state);
+}
+
+TEST_F(ExternalProtocolHandlerTest,
+    TestGetBlockStateLocalBlockResetOnProfilePref) {
+  base::DictionaryValue prefs_local;
+  prefs_local.SetBoolean("tel", true);
+  local_state_->Set(prefs::kExcludedSchemes, prefs_local);
+  ExternalProtocolHandler::BlockState block_state =
+    ExternalProtocolHandler::GetBlockState("tel", profile_.get());
+  ASSERT_EQ(ExternalProtocolHandler::UNKNOWN, block_state);

[dominickn, 2017/01/19 07:01:22]

Can you assert that the local_state_ pref is empty after this runs? And that the
profile pref has the right data in it (i.e. nothing?)

[ramyasharma, 2017/01/20 04:04:45]

Added a check to local state, to ensure it has nothing. Profile pref is not
expected to be empty though. 

+}
+
+TEST_F(ExternalProtocolHandlerTest,
+    TestGetBlockStateLocalDontBlockCopiedAsIsToProfilePref) {
+  base::DictionaryValue prefs_local;
+  prefs_local.SetBoolean("tel", false);
+  local_state_->Set(prefs::kExcludedSchemes, prefs_local);
+  ExternalProtocolHandler::BlockState block_state =
+    ExternalProtocolHandler::GetBlockState("tel", profile_.get());
+  ASSERT_EQ(ExternalProtocolHandler::DONT_BLOCK, block_state);

[dominickn, 2017/01/19 07:01:22]

Ditto

[ramyasharma, 2017/01/20 04:04:45]

Done.

+}
+