Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: chrome/browser/browsing_data/history_counter_browsertest.cc

Issue 2623033003: Always show counters in the material design Clear Browsing Data dialog. (Closed)
Patch Set: iOS fix #2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/history_counter_browsertest.cc
diff --git a/chrome/browser/browsing_data/history_counter_browsertest.cc b/chrome/browser/browsing_data/history_counter_browsertest.cc
index 0e3c32cb08d5c932f1c9b4658471e7d2618a8f8d..2fcb864fe3d0edcc24552ce350ea30a79c8fefbd 100644
--- a/chrome/browser/browsing_data/history_counter_browsertest.cc
+++ b/chrome/browser/browsing_data/history_counter_browsertest.cc
@@ -213,28 +213,6 @@ IN_PROC_BROWSER_TEST_F(HistoryCounterTest, PrefChanged) {
EXPECT_EQ(2u, GetLocalResult());
}
-// Tests that the counter does not count history if the deletion
-// preference is false.
-IN_PROC_BROWSER_TEST_F(HistoryCounterTest, PrefIsFalse) {
- SetHistoryDeletionPref(false);
- AddVisit("https://www.google.com");
-
- Profile* profile = browser()->profile();
-
- browsing_data::HistoryCounter counter(
- GetHistoryService(),
- base::Bind(&HistoryCounterTest::GetRealWebHistoryService,
- base::Unretained(this),
- base::Unretained(profile)),
- ProfileSyncServiceFactory::GetForProfile(profile));
-
- counter.Init(profile->GetPrefs(), base::Bind(&HistoryCounterTest::Callback,
- base::Unretained(this)));
- counter.Restart();
-
- EXPECT_FALSE(counter.HasTrackedTasks());
-}
-
// Tests that changing the deletion period restarts the counting, and that
// the result takes visit dates into account.
IN_PROC_BROWSER_TEST_F(HistoryCounterTest, PeriodChanged) {

Powered by Google App Engine
This is Rietveld 408576698