third_party/WebKit/Source/modules/vr/VRDisplay.cpp - Issue 2622943002: Fix WebVR requestAnimationFrame leaking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Issue 2622943002: Fix WebVR requestAnimationFrame leaking (Closed)

Patch Set: Properly fix leak Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/vr/VRDisplay.cpp

diff --git a/third_party/WebKit/Source/modules/vr/VRDisplay.cpp b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

index b2d9678e3df6bc57f8254ec94587ab0119655b2b..5193460cff93d4206d279d51d842e7346d2e8c8f 100644

--- a/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

+++ b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

@@ -752,6 +752,7 @@ const AtomicString& VRDisplay::interfaceName() const {

void VRDisplay::contextDestroyed() {

mthiesse 2017/01/13 00:34:19 Why ::contextDestroyed() rather than ::dispose()?

forceExitPresent();

+ m_scriptedAnimationController.clear();

}

bool VRDisplay::hasPendingActivity() const {