Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: third_party/WebKit/LayoutTests/vr/requestAnimationFrame_unregister.html

Issue 2622943002: Fix WebVR requestAnimationFrame leaking (Closed)
Patch Set: Rebase to see if CQ failure fixed Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <!DOCTYPE html>
2 <script src="../resources/testharness.js"></script>
3 <script src="../resources/testharnessreport.js"></script>
4 <script src="../resources/mojo-helpers.js"></script>
5 <script src="resources/fake-vr-displays.js"></script>
6 <script src="resources/mock-vr-service.js"></script>
7 <script>
8 let fakeDisplays = fakeVRDisplays();
9
10 vr_test( (t) => {
11 return navigator.getVRDisplays().then( (displays) => {
12 let display = displays[0];
13
14 function onAnimationFrameBad() {
15 t.step( () => {
16 assert_unreached();
17 }, "Unregistered callback was called");
18 t.done();
19 }
20
21 let counter = 0;
22 function onAnimationFrameGood() {
23 counter++;
24 if (counter >= 4) {
25 t.done();
26 // Intentionally don't return immediately so that display.rAF gets
27 // called again to make sure it doesn't cause unexpected behavior like
28 // it did with crbug.com/679401
29 }
30 display.requestAnimationFrame(onAnimationFrameGood);
31 }
32
33 let handle = display.requestAnimationFrame(onAnimationFrameBad);
34 display.cancelAnimationFrame(handle);
35 display.requestAnimationFrame(onAnimationFrameGood);
36 }, (err) => {
37 t.step( () => {
38 assert_unreached("getVRDisplays rejected");
39 });
40 t.done();
41 });
42 }, [fakeDisplays["Pixel"]],
43 "requestAnimationFrame callbacks can be unregistered with cancelAnimationFrame") ;
44
45 </script>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698