third_party/WebKit/LayoutTests/vr/requestAnimationFrame_invalidhandle.html - Issue 2622943002: Fix WebVR requestAnimationFrame leaking

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/vr/requestAnimationFrame_invalidhandle.html

Issue 2622943002: Fix WebVR requestAnimationFrame leaking (Closed)

Patch Set: Properly fix leak Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/vr/requestAnimationFrame_unregister.html » ('j') | third_party/WebKit/LayoutTests/vr/requestAnimationFrame_unregister.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script src="../resources/mojo-helpers.js"></script>

	5 <script src="resources/fake-vr-displays.js"></script>

	6 <script src="resources/mock-vr-service.js"></script>

	7 <script>

	8 let fakeDisplays = fakeVRDisplays();

	9

	10 vr_test( (t) => {

	11 return navigator.getVRDisplays().then( (displays) => {

	12 let display = displays[0];

	13 let canFinish = false;

	14 let counter = 0;

	15

	16 function onAnimationFrame() {

	17 display.requestAnimationFrame(onAnimationFrame);

	18 if (counter > 10) {

	19 t.done();
	sof 2017/01/13 08:41:24 this looks like it is pumping onAnimationFrame() c this looks like it is pumping onAnimationFrame() calls even after done() has been called, is that what you're after? bsheedy 2017/01/13 18:02:01 See earlier reply to your message. Show quoted text On 2017/01/13 08:41:24, sof wrote: > this looks like it is pumping onAnimationFrame() calls even after done() has > been called, is that what you're after? See earlier reply to your message.
	20 }

	21 if (counter > 0) {

	22 counter++;

	23 }

	24 if (canFinish) {

	25 canFinish = false;

	26 counter++;

	27 }

	28 }

	29

	30 let handle = display.requestAnimationFrame(onAnimationFrame);

	31 display.cancelAnimationFrame(0);

	32 display.cancelAnimationFrame(-1);

	33 display.cancelAnimationFrame(handle + 1);

	34 display.cancelAnimationFrame(handle - 1);

	35 display.cancelAnimationFrame(0.5);

	36 display.cancelAnimationFrame(null);

	37 canFinish = true;

	38 }, (err) => {

	39 t.step( () => {

	40 assert_unreached("getVRDisplays rejected");

	41 });

	42 t.done();

	43 });

	44 }, [fakeDisplays["Pixel"]],

	45 "cancelAnimationFrame does not have unexpected behavior when given invalid handl es");

	46

	47 </script>

OLD	NEW