Fixed (currently harmless) bug in test_runner and implemented separate dart2js compilation cache

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 2137 matching lines @@
   bool _closed = false;
   StreamController<TestCase> _controller = new StreamController<TestCase>();
 
   TestCaseCompleter(this.graph, this.enqueuer, this.commandQueue) {
     var eventCondition = graph.events.where;
 
     // Store all the command outputs -- they will be delivered synchronously
     // (i.e. before state changes in the graph)
     commandQueue.completedCommands.listen((CommandOutput output) {
       _outputs[output.command] = output;
+    }, onDone: () {
+      _completeTestCasesIfPossible(new List.from(enqueuer.remainingTestCases));
+      assert(enqueuer.remainingTestCases.isEmpty);
+      _checkDone();
     });
 
     // Listen for NodeState.Processing -> NodeState.{Successfull,Failed}
     // changes.
     eventCondition((event) => event is dgraph.StateChangedEvent)
         .listen((dgraph.StateChangedEvent event) {
           if (event.from == dgraph.NodeState.Processing) {
+            var command = event.node.userData;
+
             assert(COMPLETED_STATES.contains(event.to));
-            _completeTestCasesIfPossible(event.node.userData);
+            assert(_outputs[command] != null);
 
-            if (!_closed &&
-                graph.isSealed &&
-                enqueuer.remainingTestCases.isEmpty) {
-              _controller.close();
-              _closed = true;
-            }
+            _completeTestCasesIfPossible(enqueuer.command2testCases[command]);
+            _checkDone();
           }
     });
 
     // Listen also for GraphSealedEvent's. If there is not a single node in the
     // graph, we still want to finish after the graph was sealed.
     eventCondition((event) => event is dgraph.GraphSealedEvent)
         .listen((dgraph.GraphSealedEvent event) {
           if (!_closed && enqueuer.remainingTestCases.isEmpty) {
             _controller.close();
             _closed = true;
           }
     });
   }
 
   Stream<TestCase> get finishedTestCases => _controller.stream;
 
-  void _completeTestCasesIfPossible(Command command) {
-    assert(_outputs[command] != null);
+  void _checkDone() {
+    if (!_closed && graph.isSealed && enqueuer.remainingTestCases.isEmpty) {
+      _controller.close();
+      _closed = true;
+    }
+  }
 
-    var testCases = enqueuer.command2testCases[command];
-
+  void _completeTestCasesIfPossible(Iterable<TestCase> testCases){
     // Update TestCases with command outputs
     for (TestCase test in testCases) {
       for (var icommand in test.commands) {
         var output = _outputs[icommand];
         if (output != null) {
           test.commandOutputs[icommand] = output;
         }
       }
     }
 
@@ skipping 111 matching lines @@
     }
   }
 
   void eventAllTestsDone() {
     for (var listener in _eventListener) {
       listener.allDone();
     }
     _allDone();
   }
 }