Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2420)

Unified Diff: chrome/installer/util/product.h

Issue 2622883002: Remove BrowserDistribution::Type. (Closed)
Patch Set: fdoray comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/install_util_unittest.cc ('k') | chrome/installer/util/product.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/product.h
diff --git a/chrome/installer/util/product.h b/chrome/installer/util/product.h
index f3d29e89020040630f2ce5cd2f59770a90533073..0e384303980af98adccc8b54d393e63b8076930c 100644
--- a/chrome/installer/util/product.h
+++ b/chrome/installer/util/product.h
@@ -13,10 +13,11 @@
#include <vector>
#include "base/macros.h"
-#include "chrome/installer/util/browser_distribution.h"
#include "chrome/installer/util/shell_util.h"
#include "chrome/installer/util/util_constants.h"
+class BrowserDistribution;
+
namespace base {
class CommandLine;
}
@@ -52,14 +53,6 @@ class Product {
return distribution_;
}
- bool is_type(BrowserDistribution::Type type) const {
- return distribution_->GetType() == type;
- }
-
- bool is_chrome() const {
- return distribution_->GetType() == BrowserDistribution::CHROME_BROWSER;
- }
-
bool HasOption(const std::wstring& option) const {
return options_.find(option) != options_.end();
}
@@ -116,8 +109,8 @@ class Product {
MSI_STATE = 0x01
};
- BrowserDistribution* distribution_;
- std::unique_ptr<ProductOperations> operations_;
+ BrowserDistribution* const distribution_;
+ const std::unique_ptr<ProductOperations> operations_;
std::set<std::wstring> options_;
private:
« no previous file with comments | « chrome/installer/util/install_util_unittest.cc ('k') | chrome/installer/util/product.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698