Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5252)

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 2622883002: Remove BrowserDistribution::Type. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/google_chrome_distribution.cc
diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc
index 223f7d64d6f02a8985fca1c65cc8dbedccc85ca8..918c2ba0d531a311325b997529539991b6fdbf76 100644
--- a/chrome/installer/util/google_chrome_distribution.cc
+++ b/chrome/installer/util/google_chrome_distribution.cc
@@ -11,6 +11,7 @@
#include <msi.h>
#include <shellapi.h>
+#include <memory>
fdoray 2017/01/10 15:07:37 This include should be in chrome/installer/util/go
grt (UTC plus 2) 2017/01/11 08:17:54 Done.
#include <utility>
#include "base/files/file_path.h"
@@ -26,7 +27,6 @@
#include "chrome/installer/util/channel_info.h"
#include "chrome/installer/util/google_update_constants.h"
#include "chrome/installer/util/google_update_settings.h"
-#include "chrome/installer/util/helper.h"
#include "chrome/installer/util/install_util.h"
#include "chrome/installer/util/installer_util_strings.h"
#include "chrome/installer/util/l10n_string_util.h"
@@ -96,13 +96,12 @@ void NavigateToUrlWithIExplore(const base::string16& url) {
} // namespace
GoogleChromeDistribution::GoogleChromeDistribution()
- : BrowserDistribution(CHROME_BROWSER,
- std::unique_ptr<AppRegistrationData>(
- new UpdatingAppRegistrationData(kChromeGuid))) {}
+ : BrowserDistribution(std::unique_ptr<AppRegistrationData>(
fdoray 2017/01/10 15:07:37 MakeUnique<UpdatingAppRegistrationData>(kChromeGui
grt (UTC plus 2) 2017/01/11 08:17:54 Done.
+ new UpdatingAppRegistrationData(kChromeGuid))) {}
GoogleChromeDistribution::GoogleChromeDistribution(
std::unique_ptr<AppRegistrationData> app_reg_data)
- : BrowserDistribution(CHROME_BROWSER, std::move(app_reg_data)) {}
+ : BrowserDistribution(std::move(app_reg_data)) {}
void GoogleChromeDistribution::DoPostUninstallOperations(
const base::Version& version,

Powered by Google App Engine
This is Rietveld 408576698