src/debug/x64/debug-x64.cc - Issue 2622863003: [debugger] infrastructure for side-effect-free debug-evaluate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/x64/debug-x64.cc

Issue 2622863003: [debugger] infrastructure for side-effect-free debug-evaluate. (Closed)

Patch Set: clean ups. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/x64/debug-x64.cc

diff --git a/src/debug/x64/debug-x64.cc b/src/debug/x64/debug-x64.cc

index 4f80e18c859871d5352148bb491e5abc3b4ab2b9..afdc3303a2b8ad22a68a689a15fe8213c2ac897f 100644

--- a/src/debug/x64/debug-x64.cc

+++ b/src/debug/x64/debug-x64.cc

@@ -129,7 +129,7 @@ void DebugCodegen::GenerateFrameDropperLiveEdit(MacroAssembler* masm) {

__ popq(rbp);

ParameterCount dummy(0);

- __ FloodFunctionIfStepping(rdi, no_reg, dummy, dummy);

+ __ CheckDebugHook(rdi, no_reg, dummy, dummy);

// Load context from the function.

__ movp(rsi, FieldOperand(rdi, JSFunction::kContextOffset));