Chromium Code Reviews

Unified Diff: src/assembler.h

Issue 2622863003: [debugger] infrastructure for side-effect-free debug-evaluate. (Closed)
Patch Set: clean ups. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « src/api-arguments-inl.h ('k') | src/assembler.cc » ('j') | src/debug/debug.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler.h
diff --git a/src/assembler.h b/src/assembler.h
index 29a64d73cb5f86459b115bbaae7bf751cd8106e1..1cc9597cf387c3268ec2ba2a7556cc711a5cb5a7 100644
--- a/src/assembler.h
+++ b/src/assembler.h
@@ -1041,6 +1041,8 @@ class ExternalReference BASE_EMBEDDED {
Isolate* isolate);
static ExternalReference debug_is_active_address(Isolate* isolate);
+ static ExternalReference debug_hook_on_function_call_address(
+ Isolate* isolate);
static ExternalReference debug_after_break_target_address(Isolate* isolate);
static ExternalReference is_profiling_address(Isolate* isolate);
@@ -1147,7 +1149,7 @@ class CallWrapper {
// Called just after emitting a call, i.e., at the return site for the call.
virtual void AfterCall() const = 0;
// Return whether call needs to check for debug stepping.
- virtual bool NeedsDebugStepCheck() const { return false; }
+ virtual bool NeedsDebugHookCheck() const { return false; }
};
@@ -1166,7 +1168,7 @@ class CheckDebugStepCallWrapper : public CallWrapper {
virtual ~CheckDebugStepCallWrapper() {}
virtual void BeforeCall(int call_size) const {}
virtual void AfterCall() const {}
- virtual bool NeedsDebugStepCheck() const { return true; }
+ virtual bool NeedsDebugHookCheck() const { return true; }
};
« no previous file with comments | « src/api-arguments-inl.h ('k') | src/assembler.cc » ('j') | src/debug/debug.cc » ('J')

Powered by Google App Engine