Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: src/objects-inl.h

Issue 2622863003: [debugger] infrastructure for side-effect-free debug-evaluate. (Closed)
Patch Set: fix mips one more time Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 6230 matching lines...) Expand 10 before | Expand all | Expand 10 after
6241 name_should_print_as_anonymous, 6241 name_should_print_as_anonymous,
6242 kNameShouldPrintAsAnonymous) 6242 kNameShouldPrintAsAnonymous)
6243 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_anonymous_expression, 6243 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_anonymous_expression,
6244 kIsAnonymousExpression) 6244 kIsAnonymousExpression)
6245 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_function, kIsFunction) 6245 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_function, kIsFunction)
6246 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, must_use_ignition_turbo, 6246 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, must_use_ignition_turbo,
6247 kMustUseIgnitionTurbo) 6247 kMustUseIgnitionTurbo)
6248 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_flush, kDontFlush) 6248 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_flush, kDontFlush)
6249 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_asm_wasm_broken, 6249 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_asm_wasm_broken,
6250 kIsAsmWasmBroken) 6250 kIsAsmWasmBroken)
6251 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, has_no_side_effect,
6252 kHasNoSideEffect)
6253 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, computed_has_no_side_effect,
6254 kComputedHasNoSideEffect)
6251 6255
6252 bool Script::HasValidSource() { 6256 bool Script::HasValidSource() {
6253 Object* src = this->source(); 6257 Object* src = this->source();
6254 if (!src->IsString()) return true; 6258 if (!src->IsString()) return true;
6255 String* src_str = String::cast(src); 6259 String* src_str = String::cast(src);
6256 if (!StringShape(src_str).IsExternal()) return true; 6260 if (!StringShape(src_str).IsExternal()) return true;
6257 if (src_str->IsOneByteRepresentation()) { 6261 if (src_str->IsOneByteRepresentation()) {
6258 return ExternalOneByteString::cast(src)->resource() != NULL; 6262 return ExternalOneByteString::cast(src)->resource() != NULL;
6259 } else if (src_str->IsTwoByteRepresentation()) { 6263 } else if (src_str->IsTwoByteRepresentation()) {
6260 return ExternalTwoByteString::cast(src)->resource() != NULL; 6264 return ExternalTwoByteString::cast(src)->resource() != NULL;
(...skipping 2192 matching lines...) Expand 10 before | Expand all | Expand 10 after
8453 #undef WRITE_INT64_FIELD 8457 #undef WRITE_INT64_FIELD
8454 #undef READ_BYTE_FIELD 8458 #undef READ_BYTE_FIELD
8455 #undef WRITE_BYTE_FIELD 8459 #undef WRITE_BYTE_FIELD
8456 #undef NOBARRIER_READ_BYTE_FIELD 8460 #undef NOBARRIER_READ_BYTE_FIELD
8457 #undef NOBARRIER_WRITE_BYTE_FIELD 8461 #undef NOBARRIER_WRITE_BYTE_FIELD
8458 8462
8459 } // namespace internal 8463 } // namespace internal
8460 } // namespace v8 8464 } // namespace v8
8461 8465
8462 #endif // V8_OBJECTS_INL_H_ 8466 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698