[debugger] infrastructure for side-effect-free debug-evaluate.

src/objects.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/objects.h"
 
 #include <cmath>
 #include <iomanip>
 #include <memory>
 #include <sstream>
@@ skipping 10 matching lines @@
 #include "src/base/bits.h"
 #include "src/base/utils/random-number-generator.h"
 #include "src/bootstrapper.h"
 #include "src/code-stubs.h"
 #include "src/codegen.h"
 #include "src/compilation-dependencies.h"
 #include "src/compiler.h"
 #include "src/counters-inl.h"
 #include "src/counters.h"
 #include "src/date.h"
+#include "src/debug/debug-evaluate.h"
 #include "src/debug/debug.h"
 #include "src/deoptimizer.h"
 #include "src/elements.h"
 #include "src/execution.h"
 #include "src/field-index-inl.h"
 #include "src/field-index.h"
 #include "src/field-type.h"
 #include "src/frames-inl.h"
 #include "src/full-codegen/full-codegen.h"
 #include "src/globals.h"
@@ skipping 13892 matching lines @@
   shared->set_script(*script_object);
 }
 
 
 String* SharedFunctionInfo::DebugName() {
   Object* n = name();
   if (!n->IsString() || String::cast(n)->length() == 0) return inferred_name();
   return String::cast(n);
 }
 
+bool SharedFunctionInfo::IsReadOnly() {
+  if (!is_readonly_computed()) {
+    Isolate* isolate = GetIsolate();
+    if (HasBytecodeArray()) {
+      DisallowHeapAllocation not_handlified;
+      Handle<BytecodeArray> array(bytecode_array(), isolate);

[jgruber, 2017/01/10 12:46:38]

Do we need to create this handle?

And what about adding IsReadOnly to BytecodeArray instead of DebugEvaluate?
Seems more natural and we could avoid additional includes here and in
debug-evaluate.

[Yang, 2017/01/10 14:14:07]

We need to create the handle for the BytecodeArrayIterator.

I'd like to keep it this way. In fact, I should move the whitelist to src/debug.

+      set_is_readonly(DebugEvaluate::IsReadOnly(array));
+    } else {
+      set_is_readonly(false);
+    }
+    set_is_readonly_computed(true);
+  }
+  return is_readonly();
+}
+
 // The filter is a pattern that matches function names in this way:
 //   "*"      all; the default
 //   "-"      all but the top-level function
 //   "-name"  all but the function "name"
 //   ""       only the top-level function
 //   "name"   only the function "name"
 //   "name*"  only functions starting with "name"
 //   "~"      none; the tilde is not an identifier
 bool SharedFunctionInfo::PassesFilter(const char* raw_filter) {
   if (*raw_filter == '*') return true;
@@ skipping 6538 matching lines @@
       // depend on this.
       return DICTIONARY_ELEMENTS;
     }
     DCHECK_LE(kind, LAST_ELEMENTS_KIND);
     return kind;
   }
 }
 
 }  // namespace internal
 }  // namespace v8