Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2622803002: Clean-up: media::PipelineMetadata stores the rotated video size. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index a73d688ffb666568451ea1889d549ee59786de9f..08225fd79ec4ea349f8359084e87ed6905df6eac 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -1167,9 +1167,6 @@ void WebMediaPlayerImpl::OnMetadata(PipelineMetadata metadata) {
VIDEO_ROTATION_MAX + 1);
if (hasVideo()) {
- pipeline_metadata_.natural_size = GetRotatedVideoSize(
- pipeline_metadata_.video_rotation, pipeline_metadata_.natural_size);
-
if (overlay_enabled_) {
// SurfaceView doesn't support rotated video, so transition back if
// the video is now rotated. If |force_video_overlays_|, we keep the
@@ -1189,7 +1186,7 @@ void WebMediaPlayerImpl::OnMetadata(PipelineMetadata metadata) {
}
if (observer_)
- observer_->OnMetadataChanged(metadata);
+ observer_->OnMetadataChanged(pipeline_metadata_);
CreateWatchTimeReporter();
UpdatePlayState();
@@ -1329,11 +1326,8 @@ void WebMediaPlayerImpl::OnVideoNaturalSizeChange(const gfx::Size& size) {
}
client_->sizeChanged();
- if (observer_) {
- PipelineMetadata metadata = pipeline_metadata_;
- metadata.natural_size = size;
- observer_->OnMetadataChanged(metadata);
- }
+ if (observer_)
+ observer_->OnMetadataChanged(pipeline_metadata_);
}
void WebMediaPlayerImpl::OnVideoOpacityChange(bool opaque) {

Powered by Google App Engine
This is Rietveld 408576698