media/base/pipeline_metadata.h - Issue 2622803002: Clean-up: media::PipelineMetadata stores the rotated video size.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/pipeline_metadata.h

Issue 2622803002: Clean-up: media::PipelineMetadata stores the rotated video size. (Closed)

Patch Set: Addressed comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « media/base/pipeline_impl.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef MEDIA_BASE_PIPELINE_METADATA_H_	5 #ifndef MEDIA_BASE_PIPELINE_METADATA_H_

6 #define MEDIA_BASE_PIPELINE_METADATA_H_	6 #define MEDIA_BASE_PIPELINE_METADATA_H_

7	7

8 #include "base/time/time.h"	8 #include "base/time/time.h"

9 #include "media/base/audio_decoder_config.h"	9 #include "media/base/audio_decoder_config.h"

10 #include "media/base/video_decoder_config.h"	10 #include "media/base/video_decoder_config.h"

(...skipping 12 matching lines...) Expand all Loading...
23 PipelineMetadata(const PipelineMetadata&);	23 PipelineMetadata(const PipelineMetadata&);

24	24

25 // On Android, when using the MediaPlayerRenderer, \|has_video\| and \|has_audio\|	25 // On Android, when using the MediaPlayerRenderer, \|has_video\| and \|has_audio\|

26 // will be true, but the respective configs will be empty.	26 // will be true, but the respective configs will be empty.

27 // Do not make any assumptions on the validity of configs based off of the	27 // Do not make any assumptions on the validity of configs based off of the

28 // presence of audio/video.	28 // presence of audio/video.

29 bool has_audio;	29 bool has_audio;

30 bool has_video;	30 bool has_video;

31 AudioDecoderConfig audio_decoder_config;	31 AudioDecoderConfig audio_decoder_config;

32 VideoDecoderConfig video_decoder_config;	32 VideoDecoderConfig video_decoder_config;

33 gfx::Size natural_size;	33 gfx::Size natural_size; // Rotated according to \|video_rotation\|.

34 VideoRotation video_rotation;	34 VideoRotation video_rotation;

35 base::Time timeline_offset;	35 base::Time timeline_offset;

36 };	36 };

37	37

38 } // namespace media	38 } // namespace media

39	39

40 #endif // MEDIA_BASE_PIPELINE_METADATA_H_	40 #endif // MEDIA_BASE_PIPELINE_METADATA_H_

OLD	NEW