Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2622733002: Mac Support for drag-and-drop tests that start dragging via mouse simulation.

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, tfarina, jam, darin-cc_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac Support for drag-and-drop tests that start dragging via mouse simulation. This CL: 1. Adds Mac support for drag-and-drop tests that start dragging via mouse simulation. This is done by changing how drag-start event is intercepted, so that this is done in an Aura-agnostic way (by adding a test hook to RenderWidgetHostImpl::OnStartDragging). The new test hook give opportunity for more test verification (i.e. verification of img.alt text) although verification of drag start location is now only done via DOMDragEventVerifier (before this CL it was also compared with location reported via WaitUntilDragStart). 2. Moves the remainining Aura-specific functionality (for simulating external drag entering a browser window) into drag_and_drop_interactive_uitest_aura.cc (and disabling DropTextFromOutside test on Mac). BUG=647249

Patch Set 1 #

Patch Set 2 : Rebasing... #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -244 lines) Patch
A chrome/browser/ui/views/drag_and_drop_interactive_uitest.h View 1 chunk +48 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc View 1 2 21 chunks +77 lines, -241 lines 0 comments Download
A chrome/browser/ui/views/drag_and_drop_interactive_uitest_aura.cc View 1 chunk +135 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/test/data/drag_and_drop/image_source.html View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 3 chunks +20 lines, -1 line 0 comments Download
M content/public/test/browser_test_utils.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-09 22:17:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622733002/1
3 years, 11 months ago (2017-01-09 22:18:18 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-09 23:17:12 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 23:17:13 UTC) #4
Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698