Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26227005: Merge 225400 "Add "kiosk_only" manifest attribute for platform a..." (Closed)

Created:
7 years, 2 months ago by zel
Modified:
7 years, 2 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 225400 "Add "kiosk_only" manifest attribute for platform a..." > Add "kiosk_only" manifest attribute for platform apps. > > This top-level manifest attribute enforces that the app can only be installed and run in ChromeOS kiosk mode. > > BUG=284964 > TEST=added new tests > > Review URL: https://codereview.chromium.org/23604068 TBR=tengs@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -136 lines) Patch
M apps/DEPS View 2 chunks +2 lines, -0 lines 0 comments Download
M apps/launcher.cc View 3 chunks +26 lines, -7 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/app_mode/startup_app_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/fake_user_manager.h View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/fake_user_manager.cc View 4 chunks +19 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/system_display/system_display_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_basic_info.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/manifest/kiosk_enabled.html View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/manifest.json View 1 chunk +5 lines, -1 line 0 comments Download
D chrome/common/extensions/manifest_handlers/kiosk_enabled_info.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/kiosk_enabled_info.cc View 1 chunk +0 lines, -60 lines 0 comments Download
A + chrome/common/extensions/manifest_handlers/kiosk_mode_info.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/manifest_handlers/kiosk_mode_info.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_kiosk_unittest.cc View 1 chunk +57 lines, -15 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/kiosk_only_extension.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/kiosk_only_hosted_app.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/kiosk_only_invalid.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/kiosk_only_not_enabled.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/kiosk_only_packaged_app.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/kiosk_only_platform_app.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/common/manifest_constants.h View 2 chunks +4 lines, -0 lines 0 comments Download
M extensions/common/manifest_constants.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zel
7 years, 2 months ago (2013-10-09 00:40:51 UTC) #1
zel
7 years, 2 months ago (2013-10-09 00:43:13 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r227636.

Powered by Google App Engine
This is Rietveld 408576698