Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

Issue 2622633006: [Devtools] Fixes screencast when devtools is screencasting (Closed)
Patch Set: [Devtools] Fixes screencast when devtools is screencasting Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
index e8bba7b930eb6baec8524fde28f3f7d5394bd0f0..a6943525d5810349f1124ea1b691461331d75805 100644
--- a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
+++ b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
@@ -127,8 +127,10 @@ Screencast.ScreencastView = class extends UI.VBox {
}
dimensions.width *= window.devicePixelRatio;
dimensions.height *= window.devicePixelRatio;
+ // Note: startScreencast with and height expect to be integers so must be floored.
this._target.pageAgent().startScreencast(
- 'jpeg', 80, Math.min(maxImageDimension, dimensions.width), Math.min(maxImageDimension, dimensions.height));
+ 'jpeg', 80, Math.floor(Math.min(maxImageDimension, dimensions.width)),
+ Math.floor(Math.min(maxImageDimension, dimensions.height)));
this._target.emulationAgent().setTouchEmulationEnabled(true);
this._domModel.setHighlighter(this);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698