Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js

Issue 2622613003: DevTools: Type all properties on TimelinePaintProfilerView (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js
index 2cb832926ae98bbf6e294704751b4e070f67c508..23810c474c4c2b9143c16813636f5d80b3038549 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js
@@ -1,9 +1,7 @@
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-/**
- * @unrestricted
- */
+
Timeline.TimelinePaintProfilerView = class extends UI.SplitWidget {
/**
* @param {!TimelineModel.TimelineFrameModel} frameModel
@@ -28,6 +26,16 @@ Timeline.TimelinePaintProfilerView = class extends UI.SplitWidget {
this._logTreeView = new LayerViewer.PaintProfilerCommandLogView();
this._logAndImageSplitWidget.setSidebarWidget(this._logTreeView);
+
+ this._needsUpdateWhenVisible = false;
+ /** @type {?SDK.PaintProfilerSnapshot} */
+ this._pendingSnapshot = null;
+ /** @type {?SDK.TracingModel.Event} */
+ this._event = null;
+ /** @type {?SDK.Target} */
+ this._target = null;
+ /** @type {?SDK.PaintProfilerSnapshot} */
+ this._lastLoadedSnapshot = null;
}
/**
@@ -85,9 +93,10 @@ Timeline.TimelinePaintProfilerView = class extends UI.SplitWidget {
snapshotPromise = Promise.resolve({rect: null, snapshot: this._pendingSnapshot});
} else if (this._event.name === TimelineModel.TimelineModel.RecordType.Paint) {
var picture = TimelineModel.TimelineData.forEvent(this._event).picture;
- snapshotPromise = picture.objectPromise()
- .then(data => SDK.PaintProfilerSnapshot.load(this._target, data['skp64']))
- .then(snapshot => snapshot && {rect: null, snapshot: snapshot});
+ snapshotPromise =
+ picture.objectPromise()
+ .then(data => SDK.PaintProfilerSnapshot.load(/** @type {!SDK.Target} */ (this._target), data['skp64']))
+ .then(snapshot => snapshot && {rect: null, snapshot: snapshot});
} else if (this._event.name === TimelineModel.TimelineModel.RecordType.RasterTask) {
snapshotPromise = this._frameModel.rasterTilePromise(this._event);
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698