Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3039)

Unified Diff: content/renderer/BUILD.gn

Issue 2622583005: Split renderer.lib on Windows to avoid files larger than 2GB. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/BUILD.gn
diff --git a/content/renderer/BUILD.gn b/content/renderer/BUILD.gn
index 3a28c2dd4b3ddce5c7b751ee35c409b395409127..3ba70c8842314ecac159bad7bea7e71869664985 100644
--- a/content/renderer/BUILD.gn
+++ b/content/renderer/BUILD.gn
@@ -4,6 +4,7 @@
import("//build/config/features.gni")
import("//build/config/ui.gni")
+import("//build/split_static_library.gni")
import("//media/media_options.gni")
import("//ppapi/features/features.gni")
import("//printing/features/features.gni")
@@ -13,7 +14,12 @@ import("//tools/ipc_fuzzer/ipc_fuzzer.gni")
if (is_component_build) {
link_target_type = "source_set"
} else {
- link_target_type = "static_library"
+ if (is_win) {
+ # Can be too large for some windows tools if not split.
+ link_target_type = "split_static_library"
+ } else {
+ link_target_type = "static_library"
scottmg 2017/01/10 16:09:21 Can you make this like browser https://cs.chromium
Daniel Bratell 2017/01/10 20:15:50 Done.
+ }
}
target(link_target_type, "renderer") {
# Only the public target should depend on this. All other targets (even
@@ -384,6 +390,11 @@ target(link_target_type, "renderer") {
"websharedworker_proxy.h",
]
+ if (is_win && !is_component_build) {
scottmg 2017/01/10 17:51:40 If (per the bug) LTCG is mostly what makes this ha
Daniel Bratell 2017/01/10 20:15:50 Done.
+ split_count = 2 # In certain configurations a full renderer.lib can
+ # be 2+ GB which breaks some Windows tools.
+ }
+
configs += [
"//content:content_implementation",
"//build/config/compiler:no_size_t_to_int_warning",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698