Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2622583004: Use entities in all masks. (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update comment. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -118 lines) Patch
M pkg/compiler/lib/src/types/container_type_mask.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 11 chunks +33 lines, -79 lines 0 comments Download
M pkg/compiler/lib/src/types/forwarding_type_mask.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/types/map_type_mask.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 5 chunks +14 lines, -14 lines 2 comments Download
M pkg/compiler/lib/src/world.dart View 1 2 chunks +73 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/world_test.dart View 2 chunks +98 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-09 15:09:56 UTC) #2
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/2622583004/diff/20001/pkg/compiler/lib/src/types/union_type_mask.dart File pkg/compiler/lib/src/types/union_type_mask.dart (right): https://codereview.chromium.org/2622583004/diff/20001/pkg/compiler/lib/src/types/union_type_mask.dart#newcode91 pkg/compiler/lib/src/types/union_type_mask.dart:91: // TODO(johnniwinther): Move this computation to [ClosedWorld] and ...
3 years, 11 months ago (2017-01-12 00:07:48 UTC) #3
Johnni Winther
https://codereview.chromium.org/2622583004/diff/20001/pkg/compiler/lib/src/types/union_type_mask.dart File pkg/compiler/lib/src/types/union_type_mask.dart (right): https://codereview.chromium.org/2622583004/diff/20001/pkg/compiler/lib/src/types/union_type_mask.dart#newcode91 pkg/compiler/lib/src/types/union_type_mask.dart:91: // TODO(johnniwinther): Move this computation to [ClosedWorld] and use ...
3 years, 11 months ago (2017-01-12 09:58:43 UTC) #4
Johnni Winther
3 years, 11 months ago (2017-01-12 10:38:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e39ce97819effe62a516c8aaee5d407e8704e411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698