Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2622493003: Rewrite DiagnosticDomainTest using @reflectiveTest. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -72 lines) Patch
M pkg/analysis_server/test/domain_diagnostic_test.dart View 1 chunk +64 lines, -72 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-09 18:41:28 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-09 18:43:38 UTC) #2
scheglov
3 years, 11 months ago (2017-01-09 18:45:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db1950ef65445f2a1ab8893013f7dfafb90162cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698