Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2622423003: Simplify PhysicalFileSystem implementation. (Closed)

Created:
3 years, 11 months ago by Paul Berry
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Simplify PhysicalFileSystem implementation. - Use Uri.base.resolveUri() to do all necessary normalization and conversion to absolute paths. - Store a URI in _PhysicalFileSystemEntity rather than a path. - Use `new io.File.fromUri(...)` to access the physical files. - Fix some minor bugs in physical_file_system_test.dart. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/fef4569eb5a80c72b1f7b89dfac96cd78f2b19cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M pkg/front_end/lib/physical_file_system.dart View 1 chunk +8 lines, -14 lines 0 comments Download
M pkg/front_end/test/physical_file_system_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 11 months ago (2017-01-12 23:10:26 UTC) #2
Siggi Cherem (dart-lang)
lgtm, nice
3 years, 11 months ago (2017-01-12 23:13:18 UTC) #3
Paul Berry
3 years, 11 months ago (2017-01-12 23:48:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fef4569eb5a80c72b1f7b89dfac96cd78f2b19cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698