Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: ios/web/net/request_tracker_impl.mm

Issue 2622393004: Remove obsolete RequestTrackerImpl::CancelRequests. (Closed)
Patch Set: Rebase on origin/master. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/net/request_tracker_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/net/request_tracker_impl.mm
diff --git a/ios/web/net/request_tracker_impl.mm b/ios/web/net/request_tracker_impl.mm
index bc0986f98fe25f69cf509e57b8b4e29dc35b757e..99939ca45b6bd94befaf4e3fa67eff91795cba44 100644
--- a/ios/web/net/request_tracker_impl.mm
+++ b/ios/web/net/request_tracker_impl.mm
@@ -405,7 +405,6 @@ void RequestTrackerImpl::Close() {
base::Bind(
[](RequestTrackerImpl* tracker) {
tracker->is_closing_ = true;
- tracker->CancelRequests();
},
base::RetainedRef(this)));
@@ -1240,21 +1239,6 @@ NSString* RequestTrackerImpl::UnsafeDescription() {
[urls componentsJoinedByString:@"\n"]];
}
-void RequestTrackerImpl::CancelRequests() {
- DCHECK_CURRENTLY_ON(web::WebThread::IO);
- std::set<net::URLRequest*>::iterator it;
- // TODO(droger): When canceling the request, we should in theory make sure
- // that the NSURLProtocol client method |didFailWithError| is called,
- // otherwise the iOS system may wait indefinitely for the request to complete.
- // However, as we currently only cancel the requests when closing a tab, the
- // requests are all canceled by the system shortly after and nothing bad
- // happens.
- for (it = live_requests_.begin(); it != live_requests_.end(); ++it)
- (*it)->Cancel();
-
- live_requests_.clear();
-}
-
void RequestTrackerImpl::SetCertificatePolicyCacheForTest(
web::CertificatePolicyCache* cache) {
policy_cache_ = cache;
« no previous file with comments | « ios/web/net/request_tracker_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698