Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc

Issue 2622383002: Sending reporter logs doesn't depend on a feature anymore. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/srt_fetcher_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc
diff --git a/chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc b/chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc
index c336a50cbd6ec15b6c068ff85b5f6c0b9384b83d..1d29cb9f561162be3a6dce60cda0173215de0896 100644
--- a/chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc
+++ b/chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc
@@ -545,22 +545,9 @@ IN_PROC_BROWSER_TEST_F(SRTFetcherTest, MultipleLaunches) {
}
}
-IN_PROC_BROWSER_TEST_F(SRTFetcherTest, ReporterLogging_FeatureDisabled) {
- exit_code_to_report_ = kSwReporterNothingFound;
- base::test::ScopedFeatureList scoped_feature_list;
- scoped_feature_list.InitAndDisableFeature(
- kSwReporterExtendedSafeBrowsingFeature);
- RunReporter();
- TestReporterLaunchCycle({base::FilePath()});
- ExpectLoggingSwitches({/*expect no switches*/});
- ExpectLastTimeSentReportNotSet();
-}
-
IN_PROC_BROWSER_TEST_F(SRTFetcherTest, ReporterLogging_NoSBExtendedReporting) {
exit_code_to_report_ = kSwReporterNothingFound;
base::test::ScopedFeatureList scoped_feature_list;
- scoped_feature_list.InitAndEnableFeature(
- kSwReporterExtendedSafeBrowsingFeature);
RunReporter();
TestReporterLaunchCycle({base::FilePath()});
ExpectLoggingSwitches({/*expect no switches*/});
@@ -570,8 +557,6 @@ IN_PROC_BROWSER_TEST_F(SRTFetcherTest, ReporterLogging_NoSBExtendedReporting) {
IN_PROC_BROWSER_TEST_F(SRTFetcherTest, ReporterLogging_EnabledFirstRun) {
exit_code_to_report_ = kSwReporterNothingFound;
base::test::ScopedFeatureList scoped_feature_list;
- scoped_feature_list.InitAndEnableFeature(
- kSwReporterExtendedSafeBrowsingFeature);
EnableSBExtendedReporting();
// Note: don't set last time sent logs in the local state.
// SBER is enabled and there is no record in the local state of the last time
@@ -586,8 +571,6 @@ IN_PROC_BROWSER_TEST_F(SRTFetcherTest, ReporterLogging_EnabledFirstRun) {
IN_PROC_BROWSER_TEST_F(SRTFetcherTest, ReporterLogging_EnabledNoRecentLogging) {
exit_code_to_report_ = kSwReporterNothingFound;
base::test::ScopedFeatureList scoped_feature_list;
- scoped_feature_list.InitAndEnableFeature(
- kSwReporterExtendedSafeBrowsingFeature);
// SBER is enabled and last time logs were sent was more than
// |kDaysBetweenReporterLogsSent| day ago, so we should send logs in this run.
EnableSBExtendedReporting();
@@ -602,8 +585,6 @@ IN_PROC_BROWSER_TEST_F(SRTFetcherTest, ReporterLogging_EnabledNoRecentLogging) {
IN_PROC_BROWSER_TEST_F(SRTFetcherTest, ReporterLogging_EnabledRecentlyLogged) {
exit_code_to_report_ = kSwReporterNothingFound;
base::test::ScopedFeatureList scoped_feature_list;
- scoped_feature_list.InitAndEnableFeature(
- kSwReporterExtendedSafeBrowsingFeature);
// SBER is enabled, but logs have been sent less than
// |kDaysBetweenReporterLogsSent| day ago, so we shouldn't send any logs in
// this run.
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/srt_fetcher_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698