Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2622363006: Revert of Fix Incorrect date/time info under chrome://crashes. (Closed)

Created:
3 years, 11 months ago by Jia
Modified:
3 years, 11 months ago
Reviewers:
PhistucK, Wez
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix Incorrect date/time info under chrome://crashes. (patchset #4 id:60001 of https://codereview.chromium.org/2581983002/ ) Reason for revert: Drop this cl because new layout was set up in a separately cl. Original issue's description: > Fix Incorrect date/time info under chrome://crashes. > > This cl patches in the solution devised by phistuck@gmail.com. See bug 674249 for detail. > > BUG=674249 TBR=phistuck@gmail.com,wez@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=674249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M components/crash/core/browser/crashes_ui_util.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M components/crash/core/browser/resources/crashes.js View 1 chunk +5 lines, -12 lines 0 comments Download
M components/crash_strings.grdp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jia
Created Revert of Fix Incorrect date/time info under chrome://crashes.
3 years, 11 months ago (2017-01-12 22:18:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622363006/1
3 years, 11 months ago (2017-01-12 22:18:55 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 22:18:57 UTC) #5
No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698