Migrate WTF::Vector::append() to ::push_back() in WTF::HexNumber

third_party/WebKit/Source/wtf/HexNumber.h

 /*
  * Copyright (C) 2011 Research In Motion Limited. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 27 matching lines @@
 
 template <typename T>
 inline void appendByteAsHex(unsigned char byte,
                             T& destination,
                             HexConversionMode mode = Uppercase) {
   const LChar* hexDigits = Internal::hexDigitsForMode(mode);
   destination.append(hexDigits[byte >> 4]);
   destination.append(hexDigits[byte & 0xF]);
 }
 
+template <>
+inline void appendByteAsHex<Vector<LChar>>(unsigned char byte,
+                                           Vector<LChar>& destination,
+                                           HexConversionMode mode = Uppercase) {

[jsbell, 2017/01/12 23:35:26]

This should be just `HexConversionMode mode` (i.e. drop `= Uppercase`) -
apparently it inherits that from the specialized template definition. Builds
fine for me with that.

+  const LChar* hexDigits = Internal::hexDigitsForMode(mode);
+  destination.push_back(hexDigits[byte >> 4]);
+  destination.push_back(hexDigits[byte & 0xF]);
+}
+
 template <typename T>
 inline void appendUnsignedAsHex(unsigned number,
                                 T& destination,
                                 HexConversionMode mode = Uppercase) {
   const LChar* hexDigits = Internal::hexDigitsForMode(mode);
   Vector<LChar, 8> result;
   do {
     result.prepend(hexDigits[number % 16]);
     number >>= 4;
   } while (number > 0);
@@ skipping 22 matching lines @@
 }
 
 }  // namespace WTF
 
 using WTF::appendByteAsHex;
 using WTF::appendUnsignedAsHex;
 using WTF::appendUnsignedAsHexFixedSize;
 using WTF::Lowercase;
 
 #endif  // HexNumber_h