Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSMarkup.cpp

Issue 2622363005: Migrate WTF::Vector::append() to ::push_back() in WTF::HexNumber (Closed)
Patch Set: remove template, rely on function overload resolution for Vector-specific methods Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc.
5 * All rights reserved. 5 * All rights reserved.
6 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 6 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
7 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 10 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 return isCSSTokenizerIdentifier(string.characters16(), length); 70 return isCSSTokenizerIdentifier(string.characters16(), length);
71 } 71 }
72 72
73 static void serializeCharacter(UChar32 c, StringBuilder& appendTo) { 73 static void serializeCharacter(UChar32 c, StringBuilder& appendTo) {
74 appendTo.append('\\'); 74 appendTo.append('\\');
75 appendTo.append(c); 75 appendTo.append(c);
76 } 76 }
77 77
78 static void serializeCharacterAsCodePoint(UChar32 c, StringBuilder& appendTo) { 78 static void serializeCharacterAsCodePoint(UChar32 c, StringBuilder& appendTo) {
79 appendTo.append('\\'); 79 appendTo.append('\\');
80 appendUnsignedAsHex(c, appendTo, Lowercase); 80 HexNumber::appendUnsignedAsHex(c, appendTo, HexNumber::Lowercase);
81 appendTo.append(' '); 81 appendTo.append(' ');
82 } 82 }
83 83
84 void serializeIdentifier(const String& identifier, 84 void serializeIdentifier(const String& identifier,
85 StringBuilder& appendTo, 85 StringBuilder& appendTo,
86 bool skipStartChecks) { 86 bool skipStartChecks) {
87 bool isFirst = !skipStartChecks; 87 bool isFirst = !skipStartChecks;
88 bool isSecond = false; 88 bool isSecond = false;
89 bool isFirstCharHyphen = false; 89 bool isFirstCharHyphen = false;
90 unsigned index = 0; 90 unsigned index = 0;
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 String serializeURI(const String& string) { 149 String serializeURI(const String& string) {
150 return "url(" + serializeString(string) + ")"; 150 return "url(" + serializeString(string) + ")";
151 } 151 }
152 152
153 String serializeFontFamily(const String& string) { 153 String serializeFontFamily(const String& string) {
154 return isCSSTokenizerIdentifier(string) ? string : serializeString(string); 154 return isCSSTokenizerIdentifier(string) ? string : serializeString(string);
155 } 155 }
156 156
157 } // namespace blink 157 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698