Issue 2622323002: Fix an analysis error in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2622323002: Fix an analysis error in tests. (Closed)

Created:
3 years, 11 months ago by scheglov

Modified:
3 years, 11 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix an analysis error in tests. TBR R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/41f8d695b0ab0e42e27426715121432cb4d08de1

Patch Set 1 #

Total comments: 1

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/analyzer/test/generated/all_the_rest_test.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

Committed patchset #1 (id:1) manually as 41f8d695b0ab0e42e27426715121432cb4d08de1 (presubmit successful).

3 years, 11 months ago (2017-01-11 17:22:17 UTC) #3

Paul Berry

3 years, 11 months ago (2017-01-11 19:05:30 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/2622323002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2622323002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:365: void
reset({List<List<String>> packages}) {
Consider adding an assertion, e.g.:

assert(packages == null);

Just so that no one tries to call this method and pass in packages.

Alternatively, consider creating a ResolverTestCase.resetWithPackages() method
that accepts the packages argument; that way ResolverTestCase.reset() can go
back to being a zero-argument function, and we can override it safely here.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages