Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: pkg/analyzer/test/generated/resolver_test.dart

Issue 2622303006: Reapply "Add support for generic function type syntax, part 1" (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/generated/parser_test.dart ('k') | pkg/analyzer/test/generated/utilities_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/resolver_test.dart
diff --git a/pkg/analyzer/test/generated/resolver_test.dart b/pkg/analyzer/test/generated/resolver_test.dart
index a308d7822fa8f799b035a3a6dead39c9ac7a3956..725d909ddb818d9847cd15be7888cfcadc155e2c 100644
--- a/pkg/analyzer/test/generated/resolver_test.dart
+++ b/pkg/analyzer/test/generated/resolver_test.dart
@@ -412,9 +412,9 @@ class StaticTypeVerifier extends GeneralizingAstVisitor<Object> {
List<Expression> _invalidlyPropagatedExpressions = new List<Expression>();
/**
- * A list containing all of the AST TypeName nodes that were not resolved.
+ * The TypeAnnotation nodes that were not resolved.
*/
- List<TypeName> _unresolvedTypes = new List<TypeName>();
+ List<TypeAnnotation> _unresolvedTypes = new List<TypeAnnotation>();
/**
* Counter for the number of Expression nodes visited that are resolved.
@@ -444,7 +444,7 @@ class StaticTypeVerifier extends GeneralizingAstVisitor<Object> {
buffer.write(" of ");
buffer.write(_resolvedTypeCount + unresolvedTypeCount);
buffer.writeln(" type names:");
- for (TypeName identifier in _unresolvedTypes) {
+ for (TypeAnnotation identifier in _unresolvedTypes) {
buffer.write(" ");
buffer.write(identifier.toString());
buffer.write(" (");
@@ -578,9 +578,21 @@ class StaticTypeVerifier extends GeneralizingAstVisitor<Object> {
}
@override
+ Object visitTypeAnnotation(TypeAnnotation node) {
+ if (node.type == null) {
+ _unresolvedTypes.add(node);
+ } else {
+ _resolvedTypeCount++;
+ }
+ return super.visitTypeAnnotation(node);
+ }
+
+ @override
Object visitTypeName(TypeName node) {
// Note: do not visit children from this node, the child SimpleIdentifier in
// TypeName (i.e. "String") does not have a static type defined.
+ // TODO(brianwilkerson) Not visiting the children means that we won't catch
+ // type arguments that were not resolved.
if (node.type == null) {
_unresolvedTypes.add(node);
} else {
« no previous file with comments | « pkg/analyzer/test/generated/parser_test.dart ('k') | pkg/analyzer/test/generated/utilities_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698