pkg/analysis_server/lib/src/services/refactoring/extract_method.dart - Issue 2622303006: Reapply "Add support for generic function type syntax, part 1"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

Issue 2622303006: Reapply "Add support for generic function type syntax, part 1" (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/fix_internal.dart ('k') | pkg/analysis_server/lib/src/status/ast_writer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart b/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

index e904e1473aeb0a764def5f2f468b455e8b70396b..6e3c2cb4a63c457908b75dad452e7182b6526058 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

@@ -859,6 +859,15 @@ class _ExtractMethodAnalyzer extends StatementAnalyzer {

}

@override

+ Object visitGenericFunctionType(GenericFunctionType node) {

+ super.visitGenericFunctionType(node);

+ if (_isFirstSelectedNode(node)) {

+ invalidSelection('Cannot extract a single type reference.');

+ }

+ return null;

+ }

+ @override

Object visitSimpleIdentifier(SimpleIdentifier node) {

super.visitSimpleIdentifier(node);

if (_isFirstSelectedNode(node)) {