dashboard/app.yaml - Issue 2622303003: Allows a user to create_health_reports.

Side by Side Diff: dashboard/app.yaml

Issue 2622303003: Allows a user to create_health_reports. (Closed)

Patch Set: removing changes from other CL Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Python Application Configuration	1 # Python Application Configuration

2 # https://developers.google.com/appengine/docs/python/config/appconfig	2 # https://developers.google.com/appengine/docs/python/config/appconfig

3	3

4 runtime: python27	4 runtime: python27

5 api_version: 1	5 api_version: 1

6 threadsafe: false	6 threadsafe: false

7 instance_class: F4_1G	7 instance_class: F4_1G

8	8

9 libraries:	9 libraries:

10 - name: jinja2	10 - name: jinja2

(...skipping 92 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
103 - url: /bot_whitelist	103 - url: /bot_whitelist

104 script: dashboard.dispatcher.APP	104 script: dashboard.dispatcher.APP

105 login: admin	105 login: admin

106 secure: always	106 secure: always

107	107

108 - url: /change_internal_only	108 - url: /change_internal_only

109 script: dashboard.dispatcher.APP	109 script: dashboard.dispatcher.APP

110 login: admin	110 login: admin

111 secure: always	111 secure: always

112	112

	113 - url: /create_health_report

	114 script: dashboard.dispatcher.APP

	115 login: admin

	116 secure: always
	sullivan 2017/01/11 20:59:15 Why do we restrict report creation to admins? Shou Why do we restrict report creation to admins? Shouldn't it be something that all Google users can do? jessimb 2017/01/11 21:31:21 Because report creation shouldn't need to be done Show quoted text On 2017/01/11 at 20:59:15, sullivan wrote: > Why do we restrict report creation to admins? Shouldn't it be something that all Google users can do? Because report creation shouldn't need to be done but once, I thought it would make sense to keep it at a privileged level. I guess there isn't any data that people can change that isn't public. Should I just move this to entirely public? If so, I'm not sure it needs its own spot in the nav bar due to the low frequency of use. sullivan 2017/01/11 21:38:03 We should probably restrict to internal users to k Show quoted text On 2017/01/11 21:31:21, jessimb wrote: > On 2017/01/11 at 20:59:15, sullivan wrote: > > Why do we restrict report creation to admins? Shouldn't it be something that > all Google users can do? > > Because report creation shouldn't need to be done but once, I thought it would > make sense to keep it at a privileged level. I guess there isn't any data that > people can change that isn't public. > Should I just move this to entirely public? If so, I'm not sure it needs its own > spot in the nav bar due to the low frequency of use. We should probably restrict to internal users to keep spam low, and record the username of the person who created the report. jessimb 2017/01/12 02:10:30 Done Show quoted text On 2017/01/11 at 21:38:03, sullivan wrote: > On 2017/01/11 21:31:21, jessimb wrote: > > On 2017/01/11 at 20:59:15, sullivan wrote: > > > Why do we restrict report creation to admins? Shouldn't it be something that > > all Google users can do? > > > > Because report creation shouldn't need to be done but once, I thought it would > > make sense to keep it at a privileged level. I guess there isn't any data that > > people can change that isn't public. > > Should I just move this to entirely public? If so, I'm not sure it needs its own > > spot in the nav bar due to the low frequency of use. > > We should probably restrict to internal users to keep spam low, and record the username of the person who created the report. Done
	117

113 - url: /delete_expired_entities	118 - url: /delete_expired_entities

114 script: dashboard.dispatcher.APP	119 script: dashboard.dispatcher.APP

115 login: admin	120 login: admin

116 secure: always	121 secure: always

117	122

118 - url: /delete_test_data	123 - url: /delete_test_data

119 script: dashboard.dispatcher.APP	124 script: dashboard.dispatcher.APP

120 login: admin	125 login: admin

121 secure: always	126 secure: always

122	127

(...skipping 83 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
206 secure: always	211 secure: always

207	212

208 - url: /update_test_suites	213 - url: /update_test_suites

209 script: dashboard.dispatcher.APP	214 script: dashboard.dispatcher.APP

210 login: admin	215 login: admin

211 secure: always	216 secure: always

212	217

213 - url: /.*	218 - url: /.*

214 script: dashboard.dispatcher.APP	219 script: dashboard.dispatcher.APP

215 secure: always	220 secure: always

OLD	NEW

« no previous file with comments | « no previous file | dashboard/dashboard/create_health_report.py » ('j') | dashboard/dashboard/create_health_report.py » ('J')