Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 26223009: Remove SkDataTable from SkFlattenable hierarchy. (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
Reviewers:
sugoi1, reed1
CC:
skia-review_googlegroups.com, sugoi
Visibility:
Public.

Description

Remove SkDataTable from SkFlattenable hierarchy. As far as I can tell, we never really needed this. No code outside the unit test calls this code. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -89 lines) Patch
M include/core/SkDataTable.h View 4 chunks +2 lines, -9 lines 0 comments Download
M src/core/SkDataTable.cpp View 2 chunks +0 lines, -60 lines 0 comments Download
M tests/DataRefTest.cpp View 5 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
Going to punt moving this to ports back to you. Not quite sure what's the ...
7 years, 2 months ago (2013-10-15 19:28:17 UTC) #1
mtklein
CC +sugoi
7 years, 2 months ago (2013-10-15 19:49:18 UTC) #2
sugoi1
On 2013/10/15 19:49:18, mtklein wrote: > CC +sugoi lgtm
7 years, 2 months ago (2013-10-15 19:58:11 UTC) #3
reed1
lots of deletes! -- lgtm
7 years, 2 months ago (2013-10-15 20:06:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/26223009/1
7 years, 2 months ago (2013-10-15 20:07:01 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 20:40:00 UTC) #6
Message was sent while issue was closed.
Change committed as 11792

Powered by Google App Engine
This is Rietveld 408576698