Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2622283004: Speed up AOT compilation of is-tests. (Closed)

Created:
3 years, 11 months ago by Florian Schneider
Modified:
3 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Speed up AOT compilation of is-tests. * In subtype-tests in the compiler, allocate temporary objects in new-space. * Add local StackZone to avoid accumulating zone memory. * Exlude "Function" type from this optimization. Fixes #28318. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/df2ef7fd4b0e34c45d17a592d1120341cd53f14a

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M runtime/vm/precompiler.cc View 1 3 chunks +7 lines, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
3 years, 11 months ago (2017-01-11 18:58:22 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2622283004/diff/1/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/2622283004/diff/1/runtime/vm/precompiler.cc#newcode275 runtime/vm/precompiler.cc:275: StackZone stack_zone(thread_); Add a note that we might ...
3 years, 11 months ago (2017-01-11 19:09:01 UTC) #3
Florian Schneider
https://codereview.chromium.org/2622283004/diff/1/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/2622283004/diff/1/runtime/vm/precompiler.cc#newcode275 runtime/vm/precompiler.cc:275: StackZone stack_zone(thread_); On 2017/01/11 19:09:01, rmacnak wrote: > Add ...
3 years, 11 months ago (2017-01-11 19:11:14 UTC) #4
Florian Schneider
3 years, 11 months ago (2017-01-11 19:13:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
df2ef7fd4b0e34c45d17a592d1120341cd53f14a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698