chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js - Issue 2622273002: Handle login and password error for the domain join

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js

Issue 2622273002: Handle login and password error for the domain join (Closed)

Patch Set: Address Michael's comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/login/offline_ad_login.js ('k') | chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js

diff --git a/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js b/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js

index 60c0c314c39020b9c51840b7e402cabc28c96a56..5d70d5ae116a4320d88111499cb329012c9a183b 100644

--- a/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js

+++ b/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js

@@ -325,6 +325,7 @@ login.createScreen('OAuthEnrollmentScreen', 'oauth-enrollment', function() {

} else if (step == STEP_AD_JOIN) {

this.offlineAdUi_.disabled = false;

this.offlineAdUi_.setUser();

+ this.offlineAdUi_.setInvalid(ACTIVE_DIRECTORY_ERROR_STATE.NONE);

}

this.currentStep_ = step;

@@ -356,9 +357,10 @@ login.createScreen('OAuthEnrollmentScreen', 'oauth-enrollment', function() {

this.updateControlsState();

- invalidateAd: function(machineName, user) {

+ invalidateAd: function(machineName, user, errorState) {

this.offlineAdUi_.disabled = false;

this.offlineAdUi_.setUser(user, machineName);

+ this.offlineAdUi_.setInvalid(errorState);

/**