Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2013)

Unified Diff: src/debug/debug.h

Issue 2622253004: [inspector] introduced debug::SetBreakEventListener,SetExceptionEventListener (Closed)
Patch Set: addressed comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/debug/debug.cc » ('j') | src/debug/debug.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.h
diff --git a/src/debug/debug.h b/src/debug/debug.h
index 8c87325d5c7a12548998ba24bde4ab44a8bce9ce..649603fa01e86cfadb7c92d69007318a300198dc 100644
--- a/src/debug/debug.h
+++ b/src/debug/debug.h
@@ -286,7 +286,7 @@ class MessageImpl : public v8::Debug::Message {
};
// Details of the debug event delivered to the debug event listener.
-class EventDetailsImpl : public debug::EventDetails {
+class EventDetailsImpl : public v8::Debug::EventDetails {
public:
EventDetailsImpl(DebugEvent event,
Handle<JSObject> exec_state,
@@ -466,9 +466,7 @@ class Debug {
int NextAsyncTaskId(Handle<JSObject> promise);
- void SetAsyncTaskListener(debug::AsyncTaskListener listener, void* data);
- void SetCompileEventListener(debug::CompileEventListener listener,
- void* data);
+ void SetDebugEventListener(debug::DebugEventListener* listener);
// Returns whether the operation succeeded. Compilation can only be triggered
// if a valid closure is passed as the second argument, otherwise the shared
@@ -679,10 +677,7 @@ class Debug {
v8::Debug::MessageHandler message_handler_;
- debug::AsyncTaskListener async_task_listener_ = nullptr;
- void* async_task_listener_data_ = nullptr;
- debug::CompileEventListener compile_event_listener_ = nullptr;
- void* compile_event_listener_data_ = nullptr;
+ debug::DebugEventListener* debug_event_listener_ = nullptr;
static const int kQueueInitialSize = 4;
base::Semaphore command_received_; // Signaled for each command received.
« no previous file with comments | « src/api.cc ('k') | src/debug/debug.cc » ('j') | src/debug/debug.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698