Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2622153002: [Bindings] Implement installRuntimeEnabledFeatures method on some classes (Closed)
Patch Set: Work for comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
index c8aeceb69e11d4ab684653fc909a89f2e7c4a1ee..c72c8e23aeca3741dcc44a9b2aca44de74704ff7 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
@@ -254,6 +254,10 @@ def interface_context(interface, interfaces):
cpp_class_name_or_partial = cpp_name_or_partial(interface)
v8_class_name_or_partial = v8_utilities.v8_class_name_or_partial(interface)
+ # TODO(peria): Generate the target list from 'Window' and 'HTMLDocument'.
+ needs_runtime_enabled_installer = v8_class_name in [
+ 'V8Window', 'V8HTMLDocument', 'V8Document', 'V8Node', 'V8EventTarget']
+
context = {
'cpp_class': cpp_class_name,
'cpp_class_or_partial': cpp_class_name_or_partial,
@@ -279,6 +283,7 @@ def interface_context(interface, interfaces):
'is_typed_array_type': is_typed_array_type,
'lifetime': 'Dependent' if (has_visit_dom_wrapper or is_dependent_lifetime) else 'Independent',
'measure_as': v8_utilities.measure_as(interface, None), # [MeasureAs]
+ 'needs_runtime_enabled_installer': needs_runtime_enabled_installer,
'origin_trial_enabled_function': v8_utilities.origin_trial_enabled_function_name(interface),
'parent_interface': parent_interface,
'pass_cpp_type': cpp_name(interface) + '*',

Powered by Google App Engine
This is Rietveld 408576698