Improve "turn on Bluetooth" flow

Improve "turn on Bluetooth" flow

When Bluetooth is off on the device, the "device settings" link will
open a device settings page where users can turn on Bluetooth. This
CL modifies the link to pop up a dialog box (upon the same webpage) 
which asks the users if they would like to turn on Bluetooth. This
simplifies the "turn on Bluetooth" flow by staying on the same web 
bluetooth application webpage.

I uploaded some screenshots on the issue page.

BUG=676639

[juncai, 2017-01-11 02:02:38]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:03:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 03:16:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 03:16:30]

Dry run: This issue passed the CQ dry run.

[juncai, 2017-01-11 18:38:53]

Description was changed from

==========
improve turn on bluetoot flow

BUG=676639
==========

to

==========
Improve "turn on Bluetooth" flow

When Bluetooth is off on the device, the "device settings" link will
open a device settings page where users can turn on Bluetooth. This
CL modifies the link to pop up a dialog box (upon the same webpage) 
which asks the users if they would like to turn on Bluetooth. This
simplifies the "turn on Bluetooth" flow by staying on the same web 
bluetooth application webpage.

I uploaded some screenshots on the issue page.

BUG=676639
==========

[juncai, 2017-01-11 18:43:32]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 18:44:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-01-11 18:45:25]

juncai@chromium.org changed reviewers:
+ tedchoc@chromium.org

[juncai, 2017-01-11 18:45:25]

Please take a look.

[commit-bot: I haz the power, 2017-01-11 19:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:24:59]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-01-12 01:01:32]

lgtm...neat.  some suggestions here as well

https://codereview.chromium.org/2622123002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java
(right):

https://codereview.chromium.org/2622123002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java:279:
Intent intent = new Intent(BluetoothAdapter.ACTION_REQUEST_ENABLE);
some suggestions here for "safety"

Intent intent = new Intent(BluetoothAdapter.ACTION_REQUEST_ENABLE);
if (!mWindowAndroid.canResolveActivity(intent)) {
    intent = new Intent(android.provider.Settings.ACTION_BLUETOOTH_SETTINGS);
    if (!mWindow.canResolveActivity(intent)) {
         // Hide the link, or put up a toast that Chrome is unable to
         // open bluetooth settings, or something.
    }
}
IntentUtils.safeStartActivity(mContext, intent);

Basically, fall back to other intent types if your desired ones are not
supported.  Lastly, the safeStartActivity just covers the case where 
Android fails to start the activity.

[juncai, 2017-01-12 23:22:58]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 23:24:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-01-12 23:26:23]

I modified the code a little to make the chooser stay while the pop up
permissions and "turning bluetooth on" dialogs appear. Can you take a look
again? Thanks!

I also uploaded some new screenshots on the issue page.

https://codereview.chromium.org/2622123002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java
(right):

https://codereview.chromium.org/2622123002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java:279:
Intent intent = new Intent(BluetoothAdapter.ACTION_REQUEST_ENABLE);
On 2017/01/12 01:01:32, Ted C wrote:
> some suggestions here for "safety"
> 
> Intent intent = new Intent(BluetoothAdapter.ACTION_REQUEST_ENABLE);
> if (!mWindowAndroid.canResolveActivity(intent)) {
>     intent = new Intent(android.provider.Settings.ACTION_BLUETOOTH_SETTINGS);
>     if (!mWindow.canResolveActivity(intent)) {
>          // Hide the link, or put up a toast that Chrome is unable to
>          // open bluetooth settings, or something.
>     }
> }
> IntentUtils.safeStartActivity(mContext, intent);
> 
> Basically, fall back to other intent types if your desired ones are not
> supported.  Lastly, the safeStartActivity just covers the case where 
> Android fails to start the activity.

Done.

[commit-bot: I haz the power, 2017-01-13 00:05:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 00:05:03]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-01-13 16:24:04]

lgtm with naming suggestion

https://codereview.chromium.org/2622123002/diff/40001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
(right):

https://codereview.chromium.org/2622123002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:436:
public void setCloseWindowWhenLoseFocus(boolean closeWindowWhenLoseFocus) {
javadoc for public apis.

While I agree this internally resetting back to true is the right behavior, I
wonder if this name would imply that.

maybe something like:
ignorePendingWindowFocusChangeForClose or something along those lines.  It
implies a single use call.