Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/aura/window_tree_host.cc

Issue 2622103004: Mus Demo: Demonstrate external window mode (Closed)
Patch Set: Add MusDemoExternal Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« services/ui/demo/manifest_external.json ('K') | « services/ui/demo/mus_demo_unittests.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window_tree_host.cc
diff --git a/ui/aura/window_tree_host.cc b/ui/aura/window_tree_host.cc
index 039ec6daecec959a69aafabba001c85f4b746c5a..1aa7840962912f0e52d5e79a3c945442d661fb59 100644
--- a/ui/aura/window_tree_host.cc
+++ b/ui/aura/window_tree_host.cc
@@ -37,7 +37,8 @@ const char kWindowTreeHostForAcceleratedWidget[] =
float GetDeviceScaleFactorFromDisplay(Window* window) {
display::Display display =
display::Screen::GetScreen()->GetDisplayNearestWindow(window);
- DCHECK(display.is_valid());
+ // TODO: MusDemo fails in external mode because no display is available.
tonikitoo 2017/02/14 17:19:22 fixing this should be our goal now, so that we unb
fwang 2017/02/15 13:59:52 Acknowledged.
+ // DCHECK(display.is_valid());
return display.device_scale_factor();
}
« services/ui/demo/manifest_external.json ('K') | « services/ui/demo/mus_demo_unittests.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698