Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2622103002: Generalize browser controls adjustment for arbitrary scrollers. (Closed)
Patch Set: Fixed some comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index a6869a32a7d866ba1b713b2fd9424383bfaed0a9..d837f607bd27b632f6da6285eaa817aaf3d48dd8 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -417,14 +417,6 @@ class CORE_EXPORT FrameView final
void invalidatePaintForTickmarks();
- // Since the compositor can resize the viewport due to browser controls and
- // commit scroll offsets before a WebView::resize occurs, we need to adjust
- // our scroll extents to prevent clamping the scroll offsets.
- void setBrowserControlsViewportAdjustment(float);
- IntSize browserControlsSize() const {
- return IntSize(0, ceilf(m_browserControlsViewportAdjustment));
- }
-
IntSize maximumScrollOffsetInt() const override;
// ScrollableArea interface
@@ -1071,8 +1063,6 @@ class CORE_EXPORT FrameView final
Vector<IntRect> m_tickmarks;
- float m_browserControlsViewportAdjustment;
-
bool m_needsUpdateWidgetGeometries;
#if ENABLE(ASSERT)
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698