MacViews: Make window content views layer-backed.

ui/views/cocoa/native_widget_mac_nswindow.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/native_widget_mac_nswindow.h"
 
 #include "base/mac/foundation_util.h"
 #import "base/mac/sdk_forward_declarations.h"
 #import "ui/views/cocoa/bridged_native_widget.h"
 #import "ui/base/cocoa/user_interface_item_command_handler.h"
@@ skipping 23 matching lines @@
 }
 
 - (instancetype)initWithContentRect:(NSRect)contentRect
                           styleMask:(NSUInteger)windowStyle
                             backing:(NSBackingStoreType)bufferingType
                               defer:(BOOL)deferCreation {
   if ((self = [super initWithContentRect:contentRect
                                styleMask:windowStyle
                                  backing:bufferingType
                                    defer:deferCreation])) {
+    static_cast<NSView*>(self.contentView).wantsLayer = YES;

[tapted, 2017/01/13 00:22:37]

ooh neat - I think this might fix http://crbug.com/649354 ? (wdyt - I'm not sure
if I can repro that.. but if(yes) can you cite that bug here?)  At the very
least it fixes the task manager not having rounded corners, and some resize
artifacts related to that \o/ - I can make a crbug for that if 649354 doesn't
fit.

But I think there's a downside -- this will need to allocate an additional
window-sized texture. So, I think there's no point doing this for fully
transparent windows. The best place for this might be in
bridged_native_widget.mm, with

  } else {
    [[window_ contentView] setWantsLayer:YES];
  }

towards the end of BridgedNativeWidget::CreateLayer()

This will happen after BridgedNativeWidget::SetRootView(..) which may replace
the windows' contentView.


Another approach might be to check for NSTexturedBackgroundWindowMask since
they're the ones AppKit promises to give rounded bottom corners to.

(but in either case, I think BridgedNativeWidget::CreateLayer is the right place
for it -- it seems like a quirk that this manages to work, since I'm pretty sure
SetRootView() happens after the initializer here, and it should be replacing the
contentView with a new one)

     commandDispatcher_.reset([[CommandDispatcher alloc] initWithOwner:self]);
   }
   return self;
 }
 
 // This override doesn't do anything, but keeping it helps diagnose lifetime
 // issues in crash stacktraces by inserting a symbol on NativeWidgetMacNSWindow.
 - (void)dealloc {
   [super dealloc];
 }
@@ skipping 166 matching lines @@
     id appController = [NSApp delegate];
     DCHECK([appController
         conformsToProtocol:@protocol(NSUserInterfaceValidations)]);
     return [appController validateUserInterfaceItem:item];
   }
 
   return [super validateUserInterfaceItem:item];
 }
 
 @end