Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2364)

Unified Diff: components/safe_browsing_db/v4_local_database_manager.h

Issue 2622063002: Add the missing callback to client for CheckResourceUrl. (Closed)
Patch Set: Incorporate nparker@ feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/safe_browsing_db/v4_local_database_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/v4_local_database_manager.h
diff --git a/components/safe_browsing_db/v4_local_database_manager.h b/components/safe_browsing_db/v4_local_database_manager.h
index fe8ca7372993e31affe1f47167a010f57b8fc5c6..7db100dc4cee05563c71ce38dd0e76138554f3af 100644
--- a/components/safe_browsing_db/v4_local_database_manager.h
+++ b/components/safe_browsing_db/v4_local_database_manager.h
@@ -148,6 +148,10 @@ class V4LocalDatabaseManager : public SafeBrowsingDatabaseManager {
// The metadata associated with the full hash of the severest match found
// for that URL.
ThreatMetadata url_metadata;
+
+ // The full hash that matched for a blacklisted resource URL. Used only for
+ // |CheckResourceUrl| case.
+ FullHash matching_full_hash;
};
typedef std::vector<std::unique_ptr<PendingCheck>> QueuedChecks;
@@ -184,11 +188,12 @@ class V4LocalDatabaseManager : public SafeBrowsingDatabaseManager {
const std::unique_ptr<PendingCheck>& check,
FullHashToStoreAndHashPrefixesMap* full_hash_to_store_and_hash_prefixes);
- // Finds the most severe |SBThreatType| and the corresponding |metadata| from
- // |full_hash_infos|.
+ // Finds the most severe |SBThreatType| and the corresponding |metadata|, and
+ // |matching_full_hash| from |full_hash_infos|.
void GetSeverestThreatTypeAndMetadata(
SBThreatType* result_threat_type,
ThreatMetadata* metadata,
+ FullHash* matching_full_hash,
const std::vector<FullHashInfo>& full_hash_infos);
// Returns the SBThreatType for a given ListIdentifier.
« no previous file with comments | « no previous file | components/safe_browsing_db/v4_local_database_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698