Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: runtime/tools/create_snapshot_bin.py

Issue 2622053002: Refactor snapshots pieces to include a section for loading instructions into the heap of a regular … (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/isolate.cc ('k') | runtime/vm/benchmark_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/tools/create_snapshot_bin.py
diff --git a/runtime/tools/create_snapshot_bin.py b/runtime/tools/create_snapshot_bin.py
index 65e56ded00c4a23e8c24d8a135d7bc58c4df4c89..81f35aad0c9c050c7e2cd0b9e07fc623daac33c0 100755
--- a/runtime/tools/create_snapshot_bin.py
+++ b/runtime/tools/create_snapshot_bin.py
@@ -32,10 +32,6 @@ def BuildOptions():
action="store", type="string",
help="output file name into which isolate snapshot in binary form " +
"is generated")
- result.add_option("--instructions_bin",
- action="store", type="string",
- help="output file name into which instructions snapshot in assembly " +
- "form is generated")
result.add_option("--embedder_entry_points_manifest",
action="store", type="string",
help="input manifest with the vm entry points in a precompiled snapshot")
@@ -120,14 +116,8 @@ def Main():
script_args.append(''.join([ "--packages=", options.packages]))
# First setup the vm isolate and regular isolate snapshot output filename.
- script_args.append(''.join([ "--vm_isolate_snapshot=",
- options.vm_output_bin ]))
- script_args.append(''.join([ "--isolate_snapshot=", options.output_bin ]))
-
- # Setup the instuctions snapshot output filename
- if options.instructions_bin:
- script_args.append(''.join([ "--instructions_snapshot=",
- options.instructions_bin ]))
+ script_args.append(''.join([ "--vm_snapshot_data=", options.vm_output_bin ]))
+ script_args.append(''.join([ "--isolate_snapshot_data=", options.output_bin ]))
# Specify the embedder entry points snapshot
if options.embedder_entry_points_manifest:
« no previous file with comments | « runtime/lib/isolate.cc ('k') | runtime/vm/benchmark_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698