Refactor snapshots pieces to include a section for loading instructions into the heap of a regular …

runtime/vm/pages.h

Index: runtime/vm/pages.h
diff --git a/runtime/vm/pages.h b/runtime/vm/pages.h
index b3aa2cd24cae378657338b822356564ee8c2db8e..289e05d0b34243846103cae771f8aa85c06b440b 100644
--- a/runtime/vm/pages.h
+++ b/runtime/vm/pages.h
@@ -28,7 +28,7 @@ class ObjectSet;
 // A page containing old generation objects.
 class HeapPage {
  public:
-  enum PageType { kData = 0, kExecutable, kReadOnlyData, kNumPageTypes };
+  enum PageType { kData = 0, kExecutable, kNumPageTypes };

[siva, 2017/01/20 22:53:54]

See note in other file about page types.

 
   HeapPage* next() const { return next_; }
   void set_next(HeapPage* next) { next_ = next; }
@@ -231,7 +231,8 @@ class PageSpace {
   bool IsValidAddress(uword addr) const { return Contains(addr); }
 
   void VisitObjects(ObjectVisitor* visitor) const;
-  void VisitObjectsNoEmbedderPages(ObjectVisitor* visitor) const;
+  void VisitObjectsNoExternalPages(ObjectVisitor* visitor) const;
+  void VisitObjectsExternalPages(ObjectVisitor* visitor) const;

[siva, 2017/01/20 22:53:54]

The external page name here is confusing with the external size
we use for tracking the space allocated by embedder which is associated with
weak handles.

   void VisitObjectPointers(ObjectPointerVisitor* visitor) const;
 
   RawObject* FindObject(FindObjectVisitor* visitor,