Refactor snapshots pieces to include a section for loading instructions into the heap of a regular …

runtime/vm/object_graph.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object_graph.h"
 
 #include "vm/dart.h"
 #include "vm/growable_array.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
@@ skipping 131 matching lines @@
   Unmarker() {}
 
   void VisitObject(RawObject* obj) {
     if (obj->IsMarked()) {
       obj->ClearMarkBit();
     }
   }
 
   static void UnmarkAll(Isolate* isolate) {
     Unmarker unmarker;
-    isolate->heap()->VisitObjects(&unmarker);
+    isolate->heap()->VisitObjectsNoExternalPages(&unmarker);
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(Unmarker);
 };
 
 
 ObjectGraph::ObjectGraph(Thread* thread) : StackResource(thread) {
   // The VM isolate has all its objects pre-marked, so iterating over it
   // would be a no-op.
@@ skipping 43 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(InstanceAccumulator);
 };
 
 
 void ObjectGraph::IterateObjectsFrom(intptr_t class_id,
                                      ObjectGraph::Visitor* visitor) {
   NoSafepointScope no_safepoint_scope_;
   Stack stack(isolate());
 
   InstanceAccumulator accumulator(&stack, class_id);
-  isolate()->heap()->VisitObjects(&accumulator);
+  isolate()->heap()->VisitObjectsNoExternalPages(&accumulator);
 
   stack.TraverseGraph(visitor);
   Unmarker::UnmarkAll(isolate());
 }
 
 
 class SizeVisitor : public ObjectGraph::Visitor {
  public:
   SizeVisitor() : size_(0) {}
   intptr_t size() const { return size_; }
@@ skipping 427 matching lines @@
   intptr_t object_count = visitor.count();
   if (roots == kVM) {
     object_count += 1;  // root
   } else {
     object_count += 2;  // root and stack
   }
   return object_count;
 }
 
 }  // namespace dart